Skip to content

Fix Micron NVMe disk health output showing N/A #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gauravnagesh-msft wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

Fix Micron NVMe disk health output showing N/A #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sonic_platform_base/sonic_storage/ssd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
# - InnoDisk
# - StorFly
# - Virtium
# - Swissbit
# - Intel
# - Transcend
# - ATP
# - Micron

try:
import re
Expand Down Expand Up @@ -104,9 +109,9 @@ def fetch_parse_info(self, diskdev):
# Known vendor part
if self.model:
vendor = self._parse_vendor()
# For Virtium, ATP NVMe SSD, parse_generic_ssd_info should be called.
# For Virtium, ATP, Micron NVMe SSD, parse_generic_ssd_info should be called.
# Skip here, otherwise data will be overwritten by N/A.
if vendor in ['Virtium', 'ATP'] and "nvme" in self.dev:
if vendor in ['Virtium', 'ATP', 'Micron'] and "nvme" in self.dev:
return

if vendor:
Expand Down
Loading