Fixed Indentation#786
Open
dunchuan wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/backend/app/llm.py">
<violation number="1" location="apps/backend/app/llm.py:735">
P1: `FALLBACK_MAX_TOKENS` is now local to the stray `_appears_truncated` function, so `get_safe_max_tokens()` will hit `NameError` on the fallback path.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
|
||
| def _appears_truncated(data: dict, schema_type: str = "resume") -> bool: | ||
| FALLBACK_MAX_TOKENS = 4096 | ||
| FALLBACK_MAX_TOKENS = 4096 |
Contributor
There was a problem hiding this comment.
P1: FALLBACK_MAX_TOKENS is now local to the stray _appears_truncated function, so get_safe_max_tokens() will hit NameError on the fallback path.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/backend/app/llm.py, line 735:
<comment>`FALLBACK_MAX_TOKENS` is now local to the stray `_appears_truncated` function, so `get_safe_max_tokens()` will hit `NameError` on the fallback path.</comment>
<file context>
@@ -732,7 +732,7 @@ def _supports_json_mode(model_name: str) -> bool:
def _appears_truncated(data: dict, schema_type: str = "resume") -> bool:
-FALLBACK_MAX_TOKENS = 4096
+ FALLBACK_MAX_TOKENS = 4096
def get_safe_max_tokens(model_name: str, requested: int = DEFAULT_JSON_MAX_TOKENS) -> int:
</file context>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Related Issue
Description
copilot:summary
Type
Proposed Changes
Screenshots / Code Snippets (if applicable)
How to Test
Checklist
Additional Information
copilot:walkthrough
Summary by cubic
Fixes indentation in apps/backend/app/llm.py so _appears_truncated has a valid body, preventing a SyntaxError and restoring backend startup.
Written for commit d2f463a. Summary will update on new commits.