fix(operator): add startup probe to proxyrunner deployment#5300
Merged
Conversation
ChrisJBurns
approved these changes
May 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5300 +/- ##
==========================================
+ Coverage 68.36% 68.37% +0.01%
==========================================
Files 620 620
Lines 63419 63431 +12
==========================================
+ Hits 43357 43374 +17
+ Misses 16823 16817 -6
- Partials 3239 3240 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The proxyrunner only opens its 8080 listener once the upstream MCP pod is Ready. With only a
LivenessProbe(60s effective budget), cold starts slower than that are killed before the listener is up, which causes spurious proxy restarts during normal rollouts and slow MCP startup.StartupProbeto the proxyrunner container in bothdeploymentForMCPServeranddeploymentForMCPRemoteProxy. While the startup probe is active, liveness and readiness are suspended; once it passes, the existing probes take over unchanged.PeriodSeconds=5,TimeoutSeconds=3,FailureThreshold=18. 90s cold-start budget, 30s above the current effective liveness budget.Fixes #5299
Type of change
Test plan
task test)task test-e2e)task lint-fix)API Compatibility
v1beta1API, OR theapi-break-allowedlabel is applied and the migration guidance is described above.Does this introduce a user-facing change?
The proxyrunner pod now has a
StartupProbe. Existing liveness and readiness behaviour is unchanged. Net effect: proxy pods no longer restart during slow upstream cold starts.Special notes for reviewers
Probe parameters are still hardcoded. A proper fix would expose them as overrides on
MCPServer.spec.resourceOverrides.proxyDeploymentand at the operator level; that is described as a follow-up in the linked issue and intentionally not part of this PR.