Skip to content

Remove some unnecessarily duplicated code for tuples in assign() #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WardBrian merged 4 commits into from
May 20, 2025
+4 −21
Merged

Remove some unnecessarily duplicated code for tuples in assign() #3343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b6913b
Remove some unnecessarily duplicated code for tuples in assign()
WardBrian Apr 1, 2025
be4e6bc
Merge branch 'develop' into cleanup-assign-code-tuples
WardBrian Apr 24, 2025
3a601c3
Merge branch 'develop' into cleanup-assign-code-tuples
WardBrian Apr 25, 2025
a06fb41
Merge branch 'develop' into cleanup-assign-code-tuples
WardBrian May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions src/stan/model/indexing/access_helpers.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,21 +146,6 @@ void assign_impl(Mat1&& x, Mat2&& y, const char* name) {
}
}

template <typename... Types>
struct is_tuple_impl : std::false_type {};
template <typename... Types>
struct is_tuple_impl<std::tuple<Types...>> : std::true_type {};

template <typename T>
struct is_tuple : is_tuple_impl<std::decay_t<T>> {};

template <typename Tuple1, typename Tuple2,
require_all_t<internal::is_tuple<Tuple1>,
internal::is_tuple<Tuple2>>* = nullptr>
inline void assign_impl(Tuple1&& x, Tuple2&& y, const char* name) {
x = std::forward<Tuple2>(y);
}

} // namespace internal
} // namespace model
} // namespace stan
Expand Down
10 changes: 4 additions & 6 deletions src/stan/model/indexing/assign.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ namespace model {
*/

template <typename Tuple1, typename Tuple2,
require_all_t<internal::is_tuple<Tuple1>,
internal::is_tuple<Tuple2>>* = nullptr>
math::require_all_tuple_t<Tuple1, Tuple2>* = nullptr>
inline void assign(Tuple1&& x, Tuple2&& y, const char* name);

/**
Expand All @@ -60,7 +59,7 @@ inline void assign(Tuple1&& x, Tuple2&& y, const char* name);
template <
typename T, typename U,
require_t<std::is_assignable<std::decay_t<T>&, std::decay_t<U>>>* = nullptr,
require_all_not_t<internal::is_tuple<T>, internal::is_tuple<U>>* = nullptr>
math::require_all_not_tuple_t<T, U>* = nullptr>
inline void assign(T&& x, U&& y, const char* name) {
internal::assign_impl(x, std::forward<U>(y), name);
}
Expand Down Expand Up @@ -913,9 +912,8 @@ inline constexpr auto make_tuple_seq(std::integer_sequence<T, I...>) {
* @param y A tuple with elements to be assigned from
* @param name The name of the tuple to assign to
*/
template <
typename Tuple1, typename Tuple2,
require_all_t<internal::is_tuple<Tuple1>, internal::is_tuple<Tuple2>>*>
template <typename Tuple1, typename Tuple2,
math::require_all_tuple_t<Tuple1, Tuple2>*>
inline void assign(Tuple1&& x, Tuple2&& y, const char* name) {
constexpr auto t1_size = std::tuple_size<std::decay_t<Tuple1>>::value;
stan::math::for_each(
Expand Down