Align Feature tab indicator to button widths#399
Open
thomasvaeth wants to merge 3 commits intostorybookjs:mainfrom
Open
Align Feature tab indicator to button widths#399thomasvaeth wants to merge 3 commits intostorybookjs:mainfrom
thomasvaeth wants to merge 3 commits intostorybookjs:mainfrom
Conversation
👷 Deploy request for storybook-addon-catalog pending review.Visit the deploys page to approve it
|
👷 Deploy request for storybook-frontpage pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the active indicator line in the hero feature tabs, which was using hardcoded pixel offsets that didn't match the actual rendered button widths.
How
left/widthvalues with dynamic measurement viagetBoundingClientRect()using abuttonRefsarraynull— on first render the active button usesbox-shadowto avoid layout shift, then transitions to the measured indicator after the firstuseEffectrole="tablist",role="tab", andaria-selectedto the desktop tab buttonsBefore
After
