Skip to content

Align Feature tab indicator to button widths #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomasvaeth wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Align Feature tab indicator to button widths #399

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0691f09
Fixed positioning and size of indicator.
thomasvaeth Mar 27, 2026
a5e9730
Added aria-labels and roles.
thomasvaeth Mar 27, 2026
2c90a4f
Prevented flash on initial render.
thomasvaeth Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 41 additions & 10 deletions apps/frontpage/components/home/hero/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,12 @@ export function Hero({
contributorCount: string;
}) {
const [slide, setSlide] = useState(1);
const [indicator, setIndicator] = useState<{
left: number;
width: number;
} | null>(null);
const intervalId = useRef<number | null>(null);
const buttonRefs = useRef<(HTMLButtonElement | null)[]>([]);
const track = useAnalytics();

const setSlideInterval = () => {
Expand Down Expand Up @@ -97,6 +102,21 @@ export function Hero({
}
};

useEffect(() => {
const btn = buttonRefs.current[slide - 1];
if (!btn) return;

const parent = btn.parentElement;
if (!parent) return;

const parentRect = parent.getBoundingClientRect();
const btnRect = btn.getBoundingClientRect();
setIndicator({
left: btnRect.left - parentRect.left,
width: btnRect.width,
});
}, [slide]);

return (
<Container className="relative z-20 justify-between gap-20 overflow-hidden pt-12 text-white md:pt-16 lg:px-8 lg:pt-24">
<GradientBadge
Expand Down Expand Up @@ -192,26 +212,37 @@ export function Hero({
<ChevronRightIcon />
</div>
</div>
<div className="relative hidden h-20 gap-12 md:flex">
<div
className={cn(
'absolute top-0 h-0.5 bg-white transition-all',
slide === 1 && 'left-0 w-[96px]',
slide === 2 && 'left-[144px] w-[132px]',
slide === 3 && 'left-[324px] w-[101px]',
slide === 4 && 'left-[474px] w-[110px]',
)}
/>
<div
aria-label="Features"
className="relative hidden h-20 gap-12 md:flex"
role="tablist"
>
{indicator && (
<div
aria-hidden
className="absolute top-0 h-0.5 bg-white transition-all"
style={{
left: indicator.left,
width: indicator.width,
}}
/>
)}
{features.map((label, i) => (
<button
aria-selected={i === slide - 1}
className={cn(
'text-white/60 transition-colors hover:text-white',
i === slide - 1 && 'text-white',
!indicator && i === 0 && 'shadow-[inset_0_2px_0_0_white]',
)}
key={label}
onClick={() => {
handleSlideChange(i + 1);
}}
ref={(el) => {
buttonRefs.current[i] = el;
}}
role="tab"
type="button"
>
{label}
Expand Down