enhance: resolve query views using collection vchannels - #16
Merged
sunby merged 2 commits intoSep 8, 2026
Merged
Conversation
…lve qviews shards via proxy GetCollection (milvus-io#85) * enhance: drop ShardAssignmentEntry from assignment discovery and resolve qviews shards via proxy GetCollection (milvus-io#40451) Signed-off-by: chyezh <chyezh@outlook.com> * enhance: index query views by vchannel for UnknownReplicaID lookups (milvus-io#40451) Signed-off-by: chyezh <chyezh@outlook.com> * enhance: report collection vchannels directly and drop shard resolution from assignment (milvus-io#40451) Signed-off-by: chyezh <chyezh@outlook.com> --------- Signed-off-by: chyezh <chyezh@outlook.com> Signed-off-by: sunby <sunbingyi1992@gmail.com>
Signed-off-by: sunby <sunbingyi1992@gmail.com>
sunby
merged commit Sep 8, 2026
7e32a5c
into
codex/load-1m-segments-pr-stack-rebased-qv-work
10 of 13 checks passed
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve query-view shard fanout from Proxy collection metadata instead of publishing shard/replica entries through assignment discovery. Port chyezh#85: Phase 1 addresses the primary StreamingNode with an UnknownReplicaID, and Phase 2 uses the real replica ID returned in the query plan.
Adapt this branch's automatic-loading entrypoint by keeping CollectionReadiness on the Proxy query-client wrapper and implementing it through QueryCoord ShowLoadCollections/QueryServiceAvailable. This changes the readiness criterion: it no longer matches every expected vchannel against a local assignment snapshot. Each DQL request with automatic loading enabled adds a status RPC; a pending load is polled every 10 ms. The branch's PChannels list optimization and query-phase timing logs are retained.
issue: milvus-io#40451
Source PR: chyezh#85
Source commit: chyezh@e98b244
Validation:
git diff --checkandrun_clang_format.shpassed. Formatter changes outside this PR were discarded.make lint-fixran gofumpt/gci, then stopped in golangci-lint type checking because the existingC.Analyzecall passes four arguments while the local native header accepts three; the full lint target did not pass.-tags dynamic,test -gcflags="all=-N -l" -count=1.Analyze/loon_properties_inject_external_specsignatures.Review limitations: