fix(gradle-plugin): add .convention() defaults to Property<T> fields in ResolveTask#5065
Open
lfgcampos wants to merge 1 commit intoswagger-api:masterfrom
Open
fix(gradle-plugin): add .convention() defaults to Property<T> fields in ResolveTask#5065lfgcampos wants to merge 1 commit intoswagger-api:masterfrom
lfgcampos wants to merge 1 commit intoswagger-api:masterfrom
Conversation
lfgcampos
force-pushed
the
fix/gradle9-property-conventions
branch
from
341d8a5 to
84d78b1
Compare
ewaostrowska
force-pushed
the
fix/gradle9-property-conventions
branch
from
84d78b1 to
3ee8ec3
Compare
Contributor
|
Hi @lfgcampos! Thanks for pointing this issue out and putting your effort to resolve it.
|
ewaostrowska
reviewed
Apr 3, 2026
| @Optional | ||
|
|
||
| public final Property<String> encoding = getProject().getObjects().property(String.class); | ||
| public final Property<String> encoding = getProject().getObjects().property(String.class).convention(StandardCharsets.UTF_8.name()); |
Contributor
There was a problem hiding this comment.
I think this might be a behavioral change for older systems where the default was not UTF_8, so event though I would be all for having this UTF_8 here at some point for now safer version would probably be Charset.defaultCharset().name()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-core!
Please fill out the following information to help us review your PR efficiently.
Description
In Gradle 9, calling Property.get() on a property that has neither a set value nor a convention throws at runtime:
Cannot query the value of task property '...' because it has no value available.
ResolveTask.resolve() calls .get() unconditionally on prettyPrint, readAllResources, sortOutput, alwaysResolveAppPath, skipResolveAppPath, and encoding. None had a .convention(...) default, so they throw when not explicitly set by the caller.
Fix: add .convention(false) to the five boolean fields and .convention(StandardCharsets.UTF_8.name()) to encoding. Callers that set these explicitly are unaffected.
Type of Change
Checklist
Screenshots / Additional Context