Skip to content

fix(gradle-plugin): add .convention() defaults to Property<T> fields in ResolveTask #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lfgcampos wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −6
Open

fix(gradle-plugin): add .convention() defaults to Property<T> fields in ResolveTask #5065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions ...s/swagger-gradle-plugin/src/main/java/io/swagger/v3/plugins/gradle/tasks/ResolveTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import java.net.URL;
import java.net.URLClassLoader;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.Collection;
Expand Down Expand Up @@ -61,10 +62,10 @@ public enum Format {JSON, YAML, JSONANDYAML}
public final Property<String> scannerClass = getProject().getObjects().property(String.class);
@Input
@Optional
public final Property<Boolean> prettyPrint = getProject().getObjects().property(Boolean.class);
public final Property<Boolean> prettyPrint = getProject().getObjects().property(Boolean.class).convention(false);
@Input
@Optional
public final Property<Boolean> readAllResources = getProject().getObjects().property(Boolean.class);
public final Property<Boolean> readAllResources = getProject().getObjects().property(Boolean.class).convention(false);
@Input
@Optional
public final SetProperty<String> ignoredRoutes = getProject().getObjects().setProperty(String.class);
Expand All @@ -86,7 +87,7 @@ public enum Format {JSON, YAML, JSONANDYAML}
@Input
@Optional

public final Property<String> encoding = getProject().getObjects().property(String.class);
public final Property<String> encoding = getProject().getObjects().property(String.class).convention(StandardCharsets.UTF_8.name());
Copy link
Copy Markdown
Contributor

@ewaostrowska ewaostrowska Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be a behavioral change for older systems where the default was not UTF_8, so event though I would be all for having this UTF_8 here at some point for now safer version would probably be Charset.defaultCharset().name()

/**
* @since 2.0.6
*/
Expand All @@ -98,16 +99,16 @@ public enum Format {JSON, YAML, JSONANDYAML}
public final Property<String> objectMapperProcessorClass = getProject().getObjects().property(String.class);
@Input
@Optional
public final Property<Boolean> sortOutput = getProject().getObjects().property(Boolean.class);
public final Property<Boolean> sortOutput = getProject().getObjects().property(Boolean.class).convention(false);
@Input
@Optional

public final Property<Boolean> alwaysResolveAppPath = getProject().getObjects().property(Boolean.class);
public final Property<Boolean> alwaysResolveAppPath = getProject().getObjects().property(Boolean.class).convention(false);
@Input
@Optional


public final Property<Boolean> skipResolveAppPath = getProject().getObjects().property(Boolean.class);
public final Property<Boolean> skipResolveAppPath = getProject().getObjects().property(Boolean.class).convention(false);
@Input
@Optional
public final Property<String> contextId = getProject().getObjects().property(String.class);
Expand Down
Loading