services: split create and update to allow renaming#93
Open
adrianosela wants to merge 1 commit intomainfrom
Open
services: split create and update to allow renaming#93adrianosela wants to merge 1 commit intomainfrom
adrianosela wants to merge 1 commit intomainfrom
Conversation
Deprecates CreateOrUpdate in favor of Create and Update. Fixes #92
adrianosela
commented
Mar 31, 2026
| // CreateOrUpdate creates or updates a [Service]. | ||
| func (sr *ServicesResource) CreateOrUpdate(ctx context.Context, svc Service) error { | ||
| // Create creates a new [Service]. | ||
| func (sr *ServicesResource) Create(ctx context.Context, svc Service) error { |
Author
There was a problem hiding this comment.
Alternatively, we could pass a varidic option to CreateOrUpdate here like WithExistingName(name string)...
|
|
||
| // CreateOrUpdate creates or updates a [Service]. | ||
| func (sr *ServicesResource) CreateOrUpdate(ctx context.Context, svc Service) error { | ||
| // Create creates a new [Service]. |
Contributor
There was a problem hiding this comment.
The API uses PUT as an upsert - calling Create on an existing service will silently update it rather than error. Worth a doc comment noting this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates CreateOrUpdate in favor of Create and Update. The current unified approach does not support renaming a service in place without deleting and re-creating it (causing it to receive new automatically allocated IPs).
Fixes #92