-
Notifications
You must be signed in to change notification settings - Fork 16
services: split create and update to allow renaming #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adrianosela
wants to merge
1
commit into
main
Choose a base branch
from
adrianosela/92-create-or-update-does-not-allow-rename
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,8 +51,8 @@ func (sr *ServicesResource) Get(ctx context.Context, name string) (*Service, err | |
| return body[Service](sr, req) | ||
| } | ||
|
|
||
| // CreateOrUpdate creates or updates a [Service]. | ||
| func (sr *ServicesResource) CreateOrUpdate(ctx context.Context, svc Service) error { | ||
| // Create creates a new [Service]. | ||
| func (sr *ServicesResource) Create(ctx context.Context, svc Service) error { | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alternatively, we could pass a varidic option to |
||
| req, err := sr.buildRequest(ctx, http.MethodPut, sr.buildTailnetURL("vip-services", svc.Name), requestBody(svc)) | ||
| if err != nil { | ||
| return err | ||
|
|
@@ -61,6 +61,25 @@ func (sr *ServicesResource) CreateOrUpdate(ctx context.Context, svc Service) err | |
| return sr.do(req, nil) | ||
| } | ||
|
|
||
| // Update updates an existing [Service] identified by name. The name parameter | ||
| // is the current name of the service and is used to build the request URL. | ||
| // If svc.Name differs from name, the service will be renamed, preserving its | ||
| // assigned VIPs. | ||
| func (sr *ServicesResource) Update(ctx context.Context, name string, svc Service) error { | ||
| req, err := sr.buildRequest(ctx, http.MethodPut, sr.buildTailnetURL("vip-services", name), requestBody(svc)) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return sr.do(req, nil) | ||
| } | ||
|
|
||
| // CreateOrUpdate creates or updates a [Service]. | ||
| // Deprecated: use [ServicesResource.Create] or [ServicesResource.Update] instead. | ||
| func (sr *ServicesResource) CreateOrUpdate(ctx context.Context, svc Service) error { | ||
| return sr.Create(ctx, svc) | ||
| } | ||
|
|
||
| // Delete deletes a specific [Service]. | ||
| func (sr *ServicesResource) Delete(ctx context.Context, name string) error { | ||
| req, err := sr.buildRequest(ctx, http.MethodDelete, sr.buildTailnetURL("vip-services", name)) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API uses PUT as an upsert - calling Create on an existing service will silently update it rather than error. Worth a doc comment noting this.