-
Notifications
You must be signed in to change notification settings - Fork 80
feat(dbus-proxy): support for BlueZ and multiple agents #1899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
.../custom-packages/blueman-applet/0001-blueman-applet-switch-register-agent-sync-call.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # SPDX-FileCopyrightText: 2022-2026 TII (SSRC) and the Ghaf contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # This patch should be removed once the fix is merged upstream. See | ||
| # https://github.com/blueman-project/blueman/pull/3213/commits | ||
| # | ||
| From a063be21a67068eb09e6f5b14df2344eef2c756b Mon Sep 17 00:00:00 2001 | ||
| From: jkuro-tii <jaroslaw.kurowski@tii.ae> | ||
| Date: Wed, 15 Apr 2026 10:44:36 +0400 | ||
| Subject: [PATCH] blueman: fix agent registering | ||
|
|
||
| Signed-off-by: jkuro-tii <jaroslaw.kurowski@tii.ae> | ||
| --- | ||
| blueman/bluez/AgentManager.py | 2 +- | ||
| blueman/bluez/Base.py | 3 +++ | ||
| 2 files changed, 4 insertions(+), 1 deletion(-) | ||
|
|
||
| diff --git a/blueman/bluez/AgentManager.py b/blueman/bluez/AgentManager.py | ||
| index 9f266e1b..1fe249f1 100644 | ||
| --- a/blueman/bluez/AgentManager.py | ||
| +++ b/blueman/bluez/AgentManager.py | ||
| @@ -13,7 +13,7 @@ class AgentManager(Base): | ||
|
|
||
| def register_agent(self, agent_path: str, capability: str = "", default: bool = False) -> None: | ||
| param = GLib.Variant('(os)', (agent_path, capability)) | ||
| - self._call('RegisterAgent', param) | ||
| + self._call_sync('RegisterAgent', param) | ||
| if default: | ||
| default_param = GLib.Variant('(o)', (agent_path,)) | ||
| self._call('RequestDefaultAgent', default_param) | ||
| diff --git a/blueman/bluez/Base.py b/blueman/bluez/Base.py | ||
| index af645889..ab4ec9f6 100644 | ||
| --- a/blueman/bluez/Base.py | ||
| +++ b/blueman/bluez/Base.py | ||
| @@ -94,6 +94,9 @@ class Base(GObject.Object, metaclass=BaseMeta): | ||
|
|
||
| self.__proxy.call(method, param, Gio.DBusCallFlags.NONE, GLib.MAXINT, None, | ||
| callback, reply_handler, error_handler) | ||
| + | ||
| + def _call_sync(self, method: str, param: GLib.Variant | None = None) -> GLib.Variant | None: | ||
| + return self.__proxy.call_sync(method, param, Gio.DBusCallFlags.NONE, -1, None) | ||
|
|
||
| def get(self, name: str) -> Any: | ||
| try: | ||
| -- | ||
| 2.53.0 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # SPDX-FileCopyrightText: 2022-2026 TII (SSRC) and the Ghaf contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| { prev }: | ||
| prev.blueman.overrideAttrs { | ||
| patches = [ ./0001-blueman-applet-switch-register-agent-sync-call.patch ]; | ||
| } |
44 changes: 0 additions & 44 deletions
44
overlays/custom-packages/cosmic/cosmic-applets/0003-dont-use-secret-agent.patch
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 0 additions & 35 deletions
35
overlays/custom-packages/cosmic/cosmic-initial-setup/0002-dont-use-secret-agent.patch
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 0 additions & 35 deletions
35
overlays/custom-packages/cosmic/cosmic-settings/0001-dont-use-secret-agent.patch
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.