feat(dbus-proxy): support for BlueZ and multiple agents#1899
Conversation
2c89946 to
51d04ef
Compare
51d04ef to
6219409
Compare
|
It would be beneficial to test the SNI feature with it, as it also utilizes the same dbus-proxy app structure. |
6219409 to
d41e52d
Compare
d41e52d to
ba4652f
Compare
ba4652f to
5b33e8a
Compare
There was a problem hiding this comment.
Please re-enable/unhide:
- overlays/custom-packages/cosmic/cosmic-settings/default.nix
page-bluetoothcan be re-enabled- Can the secret agent disabling patch be removed?
If so, remove./0001-dont-use-secret-agent.patch
- overlays/custom-packages/cosmic/cosmic-applets/default.nix
- Can the secret agent disabling patch be removed?
If so, remove./0003-dont-use-secret-agent.patch - Remove
./0001-bluetooth-applet-hide-bluetooth-settings-button.patch
- Can the secret agent disabling patch be removed?
- overlays/custom-packages/cosmic/cosmic-initial-setup/default.nix
- Can the secret agent disabling patch be removed?
If so, remove./0002-dont-use-secret-agent.patch
- Can the secret agent disabling patch be removed?
Of course, all of these should be tested to work before committing to enabling them
5b33e8a to
869b5ea
Compare
|
In addition to the testing steps listed in the PR description, we should also test general Wi-Fi connectivity - the top panel applet, cosmic-settings network page, and cosmic-initial-setup should all be tested to ensure Wi-Fi functions work as expected. |
|
Tested on Darter Pro (new image) Tested Bluetooth & network functionality via GUI. All good. However, there are some warnings in the gui-vm log. When a Bluetooth headset was connected: After suspension (Bluetooth was disabled before suspension) I did not see any performance issues related to these warnings, but I would like your opinion about them @jkuro-tii. |
Signed-off-by: jkuro-tii <jaroslaw.kurowski@tii.ae>
|
I added a fix that switches off pipewire's support for bluetooth in gui-vm, so no longer checks BT audio devices. It's not needed as bluetooth audio devices are handled by audio-vm. |
869b5ea to
465104f
Compare
These warnings disappeared |
Description of Changes
Introduce dbus-proxy support for Bluetooth services provided by BlueZ and implement handling for multiple concurrent clients, such as NetworkManager and Bluetooth clients.
This change enables reliable operation in environments where multiple services access the D-Bus proxy simultaneously.
Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify:
Test Steps To Verify
Perform common Bluetooth operations using either the command-line tool
bluetoothctlor the graphical applicationBlueman(blueman-applet).to run
bluetoothctlenter the commands on gui-vm:1. Verify adapter power control
bluetoothctl
power on
power off
Expected result:
2. Verify device discovery (scanning)
scan on
scan off
Optional:
scan le
Expected result:
3. Verify device connection workflow
connect
disconnect
Expected result:
4. Verify pairing / agent callbacks
Initiate pairing:
pair
Or use the GUI via:
blueman-applet → Pair device
Expected result:
The proxy correctly forwards agent callbacks such as:
RequestConfirmationRequestPasskeyAuthorizeServiceand pairing completes successfully.
5. Systray support test:
Tray icons should appear from comms-vm (element-desktop) and flatpak-vm (discord, spotify, slack, etc.)
Note: Some apps close when the "X" button is clicked instead of minimizing to tray
6. Network applet tests
Expected: