refactor(foundations): change Merkle proofs code sample to Tolk#2100
refactor(foundations): change Merkle proofs code sample to Tolk#2100delovoyhomie wants to merge 4 commits intomainfrom
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 50 minutes and 45 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDocumentation example migrated from Tact to Tolk syntax for a Merkle proof tree traversal function. Changes include switching API calls ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ab7bf55 to
0a7eb9c
Compare
0a7eb9c to
b98f2e3
Compare
| // shardHashes is a hashmap (workchain -> ShardDescr). | ||
| // We only need to retrieve the ShardDescr for workchain 0, since we are working in basechain. | ||
| // `mustGet` is safe here, as we already proved that it is a valid block, and a valid masterchain block must have a ShardDescr for workchain 0. |
There was a problem hiding this comment.
[HIGH] Comment uses “we” in technical documentation
The inline code comment uses first‑person plural phrasing (“we are working in basechain” and “we already proved that it is a valid block”). The project style guide explicitly prohibits first‑person references (“we”/“I”) in documentation and code comments, requiring an impersonal, fact‑focused tone. This violates that HIGH‑severity style rule and could lead to inconsistent tone across the technical documentation. The surrounding code and comments in foundations/proofs/overview.mdx confirm that only these lines introduce the disallowed first‑person language.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
| // Cast the address to a slice and skip the 11-bit prefix | ||
| // (3 tag bits + 8 workchain bits) to reach the account ID bits. | ||
| var accountId = addr as slice; | ||
| accountId.skipBits(11); |
There was a problem hiding this comment.
Consider using this function
val (wc, hashPart) = in.senderAddress.getWorkchainAndHash();
Closes #1442
Summary by CodeRabbit