Skip to content

support intersect/minus for cypher#5116

Merged
Sophie-Xie merged 5 commits into
vesoft-inc:masterfrom
jievince:cypher-intersect
Dec 29, 2022
Merged

support intersect/minus for cypher#5116
Sophie-Xie merged 5 commits into
vesoft-inc:masterfrom
jievince:cypher-intersect

Conversation

@jievince
Copy link
Copy Markdown
Contributor

@jievince jievince commented Dec 26, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #5115,
By the way, fix #5113

Description:

Usage:
cypher_statement1 UNION/INTERSECT/MINUS cypher_statement2
e.g.

match (v:player) where id(v) == "Tony Parker" return v
union/intersect/minus
match (v:player) where id(v) == "Tim Duncan" return v

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg
Copy link
Copy Markdown
Contributor

Do we need it? As I known, it's not included in Open Cypher specification.

@jievince
Copy link
Copy Markdown
Contributor Author

Do we need it? As I known, it's not included in Open Cypher specification.

Union/Intersect/Minus is very useful. And openCypher has a pr to include them, but they forget to merge it.
opencypher/openCypher#227
neo4j/neo4j#2694

@jievince jievince added the ready-for-testing PR: ready for the CI test label Dec 28, 2022
czpmango
czpmango previously approved these changes Dec 28, 2022
@jievince jievince requested a review from czpmango December 29, 2022 02:19
@jievince jievince added the doc affected PR: improvements or additions to documentation label Dec 29, 2022
@jievince jievince requested a review from MuYiYong December 29, 2022 03:25
@MuYiYong
Copy link
Copy Markdown

good job!These will enrich our match statement capabilities, and it's better to give some examples.

@Sophie-Xie Sophie-Xie merged commit 3219930 into vesoft-inc:master Dec 29, 2022
@jievince jievince deleted the cypher-intersect branch December 30, 2022 10:32
@HarrisChu HarrisChu added the incompatible PR: incompatible with the recently released version label Jan 2, 2023
@HarrisChu
Copy link
Copy Markdown
Contributor

we have a bug before, go + return should be forbidden, e.g.

GO 3 STEP FROM {0} OVER KNOWS yield $$.Person.firstName | return count(*)

image

this pr would fix the issue, but would make it incompatible if they use go + return...

@HarrisChu
Copy link
Copy Markdown
Contributor

cc @Sophie-Xie

@abby-cyber
Copy link
Copy Markdown
Contributor

abby-cyber commented Jan 17, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc affected PR: improvements or additions to documentation incompatible PR: incompatible with the recently released version ready for review ready-for-testing PR: ready for the CI test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support intersect/minus for cypher UNION bug

8 participants