add handling for first_run script in generated build scripts#5929
Open
add handling for first_run script in generated build scripts#5929
Conversation
viambot
added
the
safe to test
viambot
added
safe to test
gmulz
force-pushed
the
gmulitz-add-first-run-to-build-tarballs
branch
from
679e45f to
1f97056
Compare
viambot
added
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a user adds a "first_run" script to their module, the generated build scripts in python and golang do not bundle the first run script and requires the user to add it manually into their build commands. this PR should add the first run script conditionally on if it is included in the meta.json
tested in go and python. my cpp setup isn't good so couldn't test how that worked, so if someone wants to pull this branch or help me get that all set up that'd be cool