Rebuild stale module-internal dependents when a dependency is re-added#5944
Draft
danielbotros wants to merge 7 commits intomainfrom
Draft
Rebuild stale module-internal dependents when a dependency is re-added#5944danielbotros wants to merge 7 commits intomainfrom
danielbotros wants to merge 7 commits intomainfrom
Conversation
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
dgottlieb
added
the
static-ignore-tests
viambot
added
safe to test
viambot
added
safe to test
danielbotros
commented
Apr 22, 2026
Comment on lines
+435
to
+449
| // Record the new dependent pointer in our entry so internalDeps stays in sync | ||
| // with the collection. This keeps `toReconfig` accurate for any downstream code | ||
| // that reads it (e.g. removeResource's filter loop matches entries by pointer | ||
| // identity — if we left toReconfig at the pre-rebuild pointer, a subsequent | ||
| // remove of the newly-rebuilt dependent wouldn't clean up this entry). | ||
| if newDependentRes != nil { | ||
| dependentName := args.conf.ResourceName() | ||
| entries := m.internalDeps[newResName] | ||
| for j := range entries { | ||
| if entries[j].conf.ResourceName() == dependentName { | ||
| entries[j].toReconfig = newDependentRes | ||
| break | ||
| } | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
The state management of the internalDeps here and below in removeResource is a overly complicated imo and can be simplified by turning it into a forward index but keeping this PR scoped.
viambot
added
safe to test
viambot
added
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.