feat: add support for parsing async_sequence<T> type#775
Conversation
|
This is now ready for review. |
saschanaz
left a comment
saschanaz
left a comment
There was a problem hiding this comment.
Mostly fine, but I do not see the change corresponding to constants:
Async iterables must not be used as the type of an attribute or constant.
The Constant interface currently has no validate() but it'll be called automatically by Container when you add it.
|
@lucacasonato, ping on updating in response to @saschanaz's comments so we can start propagating this through the spec ecosystem. |
I should probably do this myself... |
|
|
||
| if (["sequence", "record"].includes(this.idlType.generic)) { | ||
| if ( | ||
| ["async iterable", "sequence", "record"].includes(this.idlType.generic) |
There was a problem hiding this comment.
And per #1500 it should be updated a little more, to use the token async_sequence instead.
saschanaz
changed the title
async iterable<T> typeasync_sequence<T> type
The grammar isn't wrong but it's not valid. It's covered in invalid/idl instead.
|
Thanks! |
5 participants
Adds support for
async iterable<T>(whatwg/webidl#1397).