Replace incorrect "async iterable" token to "async_iterable"#1489
Merged
Conversation
Member
Author
|
And this caught a grammar problem: Seems we should change the grammar? |
Member
|
How widely deployed is this type? I suspect not very if at all? I wouldn't mind making it |
annevk
approved these changes
Jun 11, 2025
This was referenced Jul 7, 2025
Member
Author
|
Added comments to the same bugs filed by #1397 as most of them are still open. |
Member
Author
|
widlparser merged the original PR and applied the grammar change, so bikeshed is good to go once they get the new dependency. Do we have any other blockers here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the
async iterablegrammar added by #1397 toasync_iterableso that the grammar can stay withinLL(1)rule.Fixes #1490
async iterableshould be converted toasync_iterabledenoland/deno#30020async_iterable<T>WebIDL type nodejs/node#54175 (comment)async_sequence<T>type w3c/webidl2.js#775 (comment) (the comment is enough for me as a maintainer)async_iterable<T>plinss/widlparser#90(See WHATWG Working Mode: Changes for more details.)
Preview | Diff
Don't remove this comment or modify anything below this line.
If you don't want a preview generated for this pull request,
just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
Preview (#Don't…) (<a href="https://whatpr.org/webidl/1489.html#just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
<a href="https://whatpr.org/webidl/1489.html" title="Last updated on Jun 8" title="#just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
#just…) (#2025) (Preview | Preview | #9:00…) (#2025) (Diff" title="#9:00 PM UTC (e2b04a8)">Diff">#9:00…) | Diff