fix(test): de-flake VoiceRecorderTest concurrent-start cleanup#47
Merged
momentmaker merged 1 commit intomainfrom Apr 25, 2026
Merged
Conversation
…rderTest The `second start returns ConcurrentRecording without touching first` test was racing on slow CI runners: the cleanup `recorder.stop()` sometimes ran before the capture loop wrote its first buffer, so stop returned `EmptyRecording` and the assertion's `.getOrThrow()` blew up. Mirror the pattern from sibling tests by inserting `waitForCaptureProgress()` between the second-start assertion and the final stop. Surfaced as the flaky failure on dependabot PRs #31 (Hilt 1.2→1.3) and #34 (Robolectric 4.14→4.16). Both runs were unrelated to the test — their CI runners just happened to schedule the capture thread late. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
second start returns ConcurrentRecording without touching firsttest races on slow CI runners: cleanuprecorder.stop()sometimes runs before the capture loop's first buffer write, so stop returnsEmptyRecordingand.getOrThrow()blows up.waitForCaptureProgress()between the second-start assertion and the final stop.Test plan
./gradlew :app:testDebugUnitTest --tests org.walktalkmeditate.pilgrim.audio.VoiceRecorderTest --rerun-taskspasses locally🤖 Generated with Claude Code