Skip to content

fix(test): de-flake VoiceRecorderTest concurrent-start cleanup #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
momentmaker merged 1 commit into from
Apr 25, 2026
+5 −1
Merged

fix(test): de-flake VoiceRecorderTest concurrent-start cleanup #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/src/test/java/org/walktalkmeditate/pilgrim/audio/VoiceRecorderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,11 @@ class VoiceRecorderTest {

assertTrue(second.isFailure)
assertEquals(VoiceRecorderError.ConcurrentRecording, second.exceptionOrNull())
// First recording still active; stop for clean teardown.
// First recording still active; let the capture loop write at
// least one buffer before stop, otherwise the cleanup returns
// EmptyRecording on slow CI runners (race between start and the
// first AudioCapture.read).
waitForCaptureProgress()
recorder.stop().getOrThrow()
}

Expand Down