refactor(alpinejs): Fix test execution and correct minor mistakes in test files#16484
Open
rururux wants to merge 7 commits intowithastro:mainfrom
Open
refactor(alpinejs): Fix test execution and correct minor mistakes in test files#16484rururux wants to merge 7 commits intowithastro:mainfrom
rururux wants to merge 7 commits intowithastro:mainfrom
Conversation
|
rururux
commented
Apr 25, 2026
Contributor
Author
There was a problem hiding this comment.
Just a copy of packages/astro/playwright.config.js
Contributor
Author
|
I noticed that running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Changes
test:e2ecommand totest:e2e:astrotest:e2e:alpinejscommandtest:e2eto run bothtest:e2e:astroandtest:e2e:alpinejspackages/integrations/alpinejs/playwright.config.js(because CI failed without this)Previously, the test files for

integrations/alpinejswere not being run correctly.The reason is that the alpinejs integration only contains e2e tests, and those files are not picked up by the
test:integrationscommand.You can see this in the CI logs of an already-merged pull request, searching for "alpinejs" returns only one hit:
https://github.com/withastro/astro/actions/runs/24900093515/job/72915439313
To address this, I added a new
test:e2e:alpinejscommand that explicitly runs the tests for the alpinejs integration.I also moved the contents of the existing
test:e2ecommand intotest:e2e:astro, and configuredtest:e2eto run bothtest:e2e:astroandtest:e2e:alpinejs.I also noticed that
test-utils.tsfile was still using.jsas the file extension when detecting files, and another had an incorrect path to a test fixture, so I went ahead and corrected those as well.Additionally, I updated the test assertions to use a more reliable approach, as the tests were occasionally showing as flaky in CI.
Testing
Green CI
Docs
N/A, This will not affect users