-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
refactor(alpinejs): Fix test execution and correct minor mistakes in test files #16484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rururux
wants to merge
7
commits into
withastro:main
Choose a base branch
from
rururux:alpinejs-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d1d56af
Configure tests for integrations/alpinejs to run correctly
rururux 7a7d8a1
Remove redundant code
rururux e9747ae
add `playwright.config.js`
rururux 19b87d6
Revert deletion and change `.test.js` to `.test.ts`
rururux bb562ed
Correct the path to the target test fixture
rururux 9800896
Merge branch 'main' into alpinejs-test
rururux 4b39995
Change assertion to avoid flaky tests
rururux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import { defineConfig } from '@playwright/test'; | ||
|
|
||
| // NOTE: Sometimes, tests fail with `TypeError: process.stdout.clearLine is not a function` | ||
| // for some reason. This comes from Vite, and is conditionally called based on `isTTY`. | ||
| // We set it to false here to skip this odd behavior. | ||
| process.stdout.isTTY = false; | ||
|
|
||
| export default defineConfig({ | ||
| testMatch: 'test/*.test.ts', | ||
| timeout: 40_000, | ||
| expect: { | ||
| timeout: 6_000, | ||
| }, | ||
| forbidOnly: !!process.env.CI, | ||
| retries: process.env.CI ? 2 : 0, | ||
| workers: process.env.CI ? 1 : undefined, | ||
| projects: [ | ||
| { | ||
| name: 'Chrome Stable', | ||
| use: { | ||
| browserName: 'chromium', | ||
| channel: 'chrome', | ||
| }, | ||
| }, | ||
| ], | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a copy of
packages/astro/playwright.config.js