fix(addon-image): use device pixel dimensions for HiDPI rendering#5775
Draft
mgabor3141 wants to merge 1 commit intoxtermjs:masterfrom
Draft
fix(addon-image): use device pixel dimensions for HiDPI rendering#5775mgabor3141 wants to merge 1 commit intoxtermjs:masterfrom
mgabor3141 wants to merge 1 commit intoxtermjs:masterfrom
Conversation
The image addon canvas was sized using CSS pixel dimensions, ignoring devicePixelRatio. On HiDPI displays this caused images to render at half (or less) resolution, appearing blurry compared to native terminal emulators. Fix by: - Using dimensions.device.* for canvas backing store size and all draw/clear coordinates (cell size, canvas size) - Setting canvas.style.width/height to CSS dimensions for display - This matches how the WebGL renderer handles DPR scaling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image addon canvas is sized using CSS pixel dimensions, ignoring devicePixelRatio. On HiDPI displays images render at lower resolution, appearing blurry.
Fix: use
dimensions.device.*for the canvas backing store and all draw/clear coordinates, while settingcanvas.style.width/heightto CSS dimensions for display sizing.Fixes #5035