Skip to content

Allow to select target by general css selector. - #73

Open
aratak wants to merge 1 commit into
zurb:masterfrom
aratak:select-element-by-selector
Open

Allow to select target by general css selector.#73
aratak wants to merge 1 commit into
zurb:masterfrom
aratak:select-element-by-selector

Conversation

@aratak

@aratak aratak commented Feb 22, 2013

Copy link
Copy Markdown
  <li data-selector="header > #menu #profile">Tip content...</li>

@juuliaans

Copy link
Copy Markdown
Contributor

This is cool! i like it.

@colllin

colllin commented Mar 23, 2013

Copy link
Copy Markdown

I was thinking the same thing. Do you think data-target would be a clearer name for it?

I would be in favor of removing data-id and data-class support. Not that you could do that, for backwards compatibility, but they could be removed from the documentation in favor of data-target.

@mburtscher

Copy link
Copy Markdown

I'd really like to see that feature. Just opened exactly the same pull request o_0

@spilliton

Copy link
Copy Markdown

I could use this as well 👍

@aentan

aentan commented Jun 17, 2013

Copy link
Copy Markdown

Is this going to be pulled?

@aratak

aratak commented Jun 17, 2013

Copy link
Copy Markdown
Author

@aentan, +1.
Seems, @zurb forget about current PR.

@parrish

parrish commented Jul 22, 2013

Copy link
Copy Markdown

I was just about to fork and send a PR for this. Is there a reason this hasn't been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants