Skip to content

Update ip_2d_feature_extraction: Fix tests (add fp tolerance via regex)#189

Merged
kostrykin merged 1 commit intoBMCV:masterfrom
kostrykin:dev/2d_feature_extraction
Jan 5, 2026
Merged

Update ip_2d_feature_extraction: Fix tests (add fp tolerance via regex)#189
kostrykin merged 1 commit intoBMCV:masterfrom
kostrykin:dev/2d_feature_extraction

Conversation

@kostrykin
Copy link
Copy Markdown
Member

@kostrykin kostrykin commented Jan 5, 2026

https://github.com/BMCV/galaxy-image-analysis/actions/runs/20702074412
Weekly tests failed after #183 due to

Output output:  different than expected, difference (using diff):
( /tmp/tmp6sef4feqinput9.tsv v. /tmp/tmp6q77cy2cinput9.tsv )
--- local_file
+++ history_data
@@ -1,2 +1,2 @@
 area	area_convex	area_filled	axis_major_length	axis_minor_length	bbox	centroid	equivalent_diameter_area	euler_number	extent	inertia_tensor_eigvals	moments	perimeter	solidity	max_intensity	mean_intensity	min_intensity
-10076.0	19452.0	10076.0	141.5372589111894	2.2275554354875524	[0, 0, 0, 2, 100, 100]	[0.4791583961889639, 51.02153632393807, 55.51121476776498]	26.797637758267182	-1	0.5038	[1633.5242978752312, 1001.887883165562, 632.1326150314862]	[[[10076.0, 559331.0, 39680985.0, 3075710795.0], [514093.0, 26719026.0, 1828782204.0, 137703070104.0], [34057349.0, 1680671976.0, 112117199682.0, 8307987945522.0], [2545051621.0, 120295106826.0, 7853098605480.0, 574813269790152.0]], [[4828.0, 278845.0, 20126387.0, 1574048161.0], [246982.0, 13386366.0, 940613844.0, 72136219614.0], [16531236.0, 855530424.0, 59225271630.0, 4513705336536.0], [1248767206.0, 62249971170.0, 4259056106556.0, 323493844156146.0]], [[4828.0, 278845.0, 20126387.0, 1574048161.0], [246982.0, 13386366.0, 940613844.0, 72136219614.0], [16531236.0, 855530424.0, 59225271630.0, 4513705336536.0], [1248767206.0, 62249971170.0, 4259056106556.0, 323493844156146.0]], [[4828.0, 278845.0, 20126387.0, 1574048161.0], [246982.0, 13386366.0, 940613844.0, 72136219614.0], [16531236.0, 855530424.0, 59225271630.0, 4513705336536.0], [1248767206.0, 62249971170.0, 4259056106556.0, 323493844156146.0]]]	10076	0.5179930084310097	999.8037382034536	523.4422397609023	0.11458563869848337
+10076.0	19452.0	10076.0	141.53725891118944	2.227555435489594	[0, 0, 0, 2, 100, 100]	[0.4791583961889639, 51.02153632393807, 55.51121476776498]	26.797637758267182	-1	0.5038	[1633.5242978752312, 1001.8878831655629, 632.1326150314862]	[[[10076.0, 559331.0, 39680985.0, 3075710795.0], [514093.0, 26719026.0, 1828782204.0, 137703070104.0], [34057349.0, 1680671976.0, 112117199682.0, 8307987945522.0], [2545051621.0, 120295106826.0, 7853098605480.0, 574813269790152.0]], [[4828.0, 278845.0, 20126387.0, 1574048161.0], [246982.0, 13386366.0, 940613844.0, 72136219614.0], [16531236.0, 855530424.0, 59225271630.0, 4513705336536.0], [1248767206.0, 62249971170.0, 4259056106556.0, 323493844156146.0]], [[4828.0, 278845.0, 20126387.0, 1574048161.0], [246982.0, 13386366.0, 940613844.0, 72136219614.0], [16531236.0, 855530424.0, 59225271630.0, 4513705336536.0], [1248767206.0, 62249971170.0, 4259056106556.0, 323493844156146.0]], [[4828.0, 278845.0, 20126387.0, 1574048161.0], [246982.0, 13386366.0, 940613844.0, 72136219614.0], [16531236.0, 855530424.0, 59225271630.0, 4513705336536.0], [1248767206.0, 62249971170.0, 4259056106556.0, 323493844156146.0]]]	10076	0.5179930084310097	999.8037382034536	523.4422397609023	0.11458563869848337

This is fixed here by utilizing compare="re_match" for floating point comparison.

@kostrykin kostrykin added Partitioning and Detection Image segmentation, partitioning, and detection skip-version-check labels Jan 5, 2026
@kostrykin kostrykin merged commit 96cd7ca into BMCV:master Jan 5, 2026
11 checks passed
@kostrykin kostrykin deleted the dev/2d_feature_extraction branch January 5, 2026 13:30
@kostrykin
Copy link
Copy Markdown
Member Author

Attention: deployment skipped!

https://github.com/BMCV/galaxy-image-analysis/actions/runs/20716938897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partitioning and Detection Image segmentation, partitioning, and detection skip-version-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant