Fix #8863: Point-blank shot offered no turret rotation, and would not fire

[HammerGS]

What this changes

A hidden unit can now rotate its turret before its point-blank shot, and the shot itself works.

Total Warfare p.260 lets a revealed hidden unit torso twist or rotate its turret before firing. Twist was wired up; rotation was not offered at all, so a turreted vehicle had to fire on whatever facing it had been hiding with.

Testing that turned up three further faults in the same shot. They are in here because without them the rotation is either unreachable or invisible, so the original fix could not be verified on its own.

The button. PointblankShotDisplay declares its own command set, and it had no rotate commands, which left rotateSelectedMount, rotateRearTurret and updateRotateTurret unreachable even though the shared parent implements all three. Adds both commands, mirroring the firing phase. The rear-turret button appears only for a dual-turret vehicle, as it does there.

The trigger. The shot only fired when the moving unit stopped next to the hidden one, so walking past it did nothing. TW p.260 keys the shot on being revealed by enemy movement, and adds that the target "may continue its move after the attack" when it has MP left, which is only possible part way through a move. The rule now lives in Compute.revealsHiddenUnitForPointblankShot, next to the related detection rule, and is covered by tests.

The crash. Pressing Fire threw a NullPointerException from setFireChargeLevelEnabled. PointblankShotDisplay has its own button map, so the parent's is never filled; it overrides ten of the twenty-two button setters and inherits the rest, and any inherited one reached into a null map. Disabling the buttons on Fire hit exactly that. Every setter now goes through one null-safe helper, rather than adding a single override and leaving the other twelve waiting.

The ranges. The field of fire only followed the turret during the firing, targeting and offboard phases. A point-blank shot is aimed during the enemy's movement phase, so the arc was drawn from the hull facing and rotating the turret changed the displayed ranges by nothing. It now asks whether the player is aiming rather than which phase it is.

The redraw. The facing dialog is not modal, so refreshing straight after setVisible ran before the player had chosen anything. It is now a callback on accept, and it rebuilds the weapon panel, which is what the arc is drawn from.

Fixes #8863

Testing

Tested in game, on an Ajax Assault Tank Prime hidden against a moving Mek. All four behaviours confirmed: the turret rotates, the shot triggers when the enemy walks past rather than only when it stops, Fire completes without throwing, and the range overlay follows the turret.

compileJava, checkstyleMain, checkstyleTest and javadoc pass. ComputeTest is 32 tests, 0 failures.

Three new tests pin the trigger rule: a ground mover reveals at range 0 and 1 and not at 2, an airborne mover without an Active Probe reveals only what it overflies, and one with a probe reveals the adjacent hex instead.

What is not proven yet

• Only a single-turret vehicle was played. The dual-turret case is untried, front and rear buttons and their labels being the fiddliest part.
• A Mek turret and a 360 directional torso mount go down the same rotation path and are also untried.
• The airborne side of the trigger rule is covered by unit tests only. No aerospace unit has been flown over a hidden unit against this build.
• Single player only. The server now echoes a mount facing change, so a second client seeing the turret move has not been observed.

Out of scope

Vehicles never rotate their turret graphic on the board: only Meks and ProtoMeks pick their sprite by secondary facing. A vehicle's turret facing shows as the green arrow and in the dialog, which is the existing behaviour everywhere and is left alone.

Three direct button-map lookups outside the setters, in the called-shot hotkey and the RHS update, have the same null-map fault and are untouched here.

---

• This PR is focused on one issue or RFE - the point-blank shot; the extra fixes are what made the rotation reachable and visible
• Every file in the diff has a deliberate change
• Tests added or updated, if this implements a rule or changes game state
• Javadoc literals use {@code true} / {@code null} rather than bare or quoted text
• Dev team only: AI tools used -> AI Assisted Development label applied

[Copilot]

🔵 Needs a closer look

The change affects gameplay-critical UI wiring for a rare rules path and is explicitly untested in-game with no automated coverage, so it needs human verification before approval.

Pull request overview

This PR fixes a UI/phase-display gap in the point-blank shot flow for hidden units: the point-blank display now exposes the same turret-rotation actions that already exist in the shared attack-phase logic, aligning the UI with Total Warfare p.260 and resolving #8863.

Changes:

• Adds point-blank phase commands for rotating the selected turret/mount and (when applicable) the rear turret.
• Wires the new commands into button visibility/enabling/labeling and the action handler, mirroring firing-phase behavior.
• Ensures rotate-turret enablement state is refreshed when selecting an entity during the point-blank shot display.

File summaries

File	Description
megamek/src/megamek/client/ui/panels/phaseDisplay/PointblankShotDisplay.java	Adds rotate-turret commands and hooks them into point-blank shot UI so turret rotation is offered (including dual-turret rear rotation gating).

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[HammerGS]

Tested in game and working. Out of draft.

An Ajax Assault Tank Prime hidden against a moving Mek. The turret rotates, the shot triggers when the enemy walks past rather than only when it stops, Fire completes without throwing, and the range overlay follows the turret.

Scope grew from the original issue and the notes say why: fixing the rotation button revealed that the shot could not be reached or seen. The trigger waited for the mover to stop, Fire threw on a null button map, and the field of fire asked which phase the game was in, which is never the firing phase for a point-blank shot.

[Copilot]

🔵 Needs a closer look

It spans a repo-wide firing-button setter refactor, a movement/point-blank trigger rule change, and a client broadcast, with several paths (dual-turret, Mek turret, aerospace, multiplayer) the author states are unverified.

Review details

• Files reviewed: 8/8 changed files
• Comments generated: 2
• Review effort level: Balanced