Skip to content

[19.0][MIG] calendar_public_holiday: Migration to 19.0#186

Open
tishmen wants to merge 3 commits into
OCA:19.0from
tishmen:19.0-mig-calendar_public_holiday-v2
Open

[19.0][MIG] calendar_public_holiday: Migration to 19.0#186
tishmen wants to merge 3 commits into
OCA:19.0from
tishmen:19.0-mig-calendar_public_holiday-v2

Conversation

@tishmen
Copy link
Copy Markdown

@tishmen tishmen commented Oct 19, 2025

Scope

  • calendar_public_holiday only

Summary

  • Migrate to Odoo 19 using the working feature branch code.
  • Context handling aligned with 19.0.
  • Asset paths are relative under web.assets_backend.

Pre-commit

  • Verified locally; no additional changes applied here to keep parity with the feature branch.

Tests
Command:

./odoo/odoo-bin -c odoo.conf -d odoo_calendar_tests_public_holiday_001 \
  -i calendar_public_holiday \
  --test-enable --test-tags "/calendar_public_holiday" \
  --log-level=info --stop-after-init

Result: 13 tests green locally.

@tishmen
Copy link
Copy Markdown
Author

tishmen commented Oct 19, 2025

Supersedes #181 to preserve history per OCA 19.0 migration process.

@cuongnmtm
Copy link
Copy Markdown

Hi @tishmen , I don't see the commit history of this module in the PR.

This specific command does the job git format-patch --keep-subject --stdout origin/19.0..origin/18.0 -- $module | git am -3 --keep, but you should follow all the steps in this guideline https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0#technical-method-to-migrate-a-module-from-180-to-190-branch

Copy link
Copy Markdown

@cuongnmtm cuongnmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the previous comment. Thanks.

@leemannd
Copy link
Copy Markdown

leemannd commented Feb 26, 2026

Hello, to favor a prompt resolution of the migration of the module I am superseeding it in #203

Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be closed because the module has already been merged here: https://github.com/OCA/calendar/tree/18.0/calendar_public_holiday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants