Skip to content

[19.0][MIG]calendar_public_holiday#203

Merged
OCA-git-bot merged 9 commits into
OCA:19.0from
camptocamp:19.0-mig-calendar_public_holiday
Mar 2, 2026
Merged

[19.0][MIG]calendar_public_holiday#203
OCA-git-bot merged 9 commits into
OCA:19.0from
camptocamp:19.0-mig-calendar_public_holiday

Conversation

@leemannd
Copy link
Copy Markdown

@leemannd leemannd commented Feb 26, 2026

As there is no progress on the original PR since october 19 2025, I am taking over the migration of the module calendar_public_holiday.

I have cherry-picked the commit from the previous author.

Superseeds #186

@leemannd leemannd changed the title 19.0 mig calendar public holiday 19.0 mig calendar_public_holiday Feb 26, 2026
oca-ci and others added 7 commits February 26, 2026 15:54
Translated using Weblate (Italian)

Currently translated at 97.1% (34 of 35 strings)

Translation: calendar-18.0/calendar-18.0-calendar_public_holiday
Translate-URL: https://translation.odoo-community.org/projects/calendar-18-0/calendar-18-0-calendar_public_holiday/it/

Translated using Weblate (Italian)

Currently translated at 100.0% (35 of 35 strings)

Translation: calendar-18.0/calendar-18.0-calendar_public_holiday
Translate-URL: https://translation.odoo-community.org/projects/calendar-18-0/calendar-18-0-calendar_public_holiday/it/
Translated using Weblate (Spanish)

Currently translated at 94.2% (33 of 35 strings)

Translation: calendar-18.0/calendar-18.0-calendar_public_holiday
Translate-URL: https://translation.odoo-community.org/projects/calendar-18-0/calendar-18-0-calendar_public_holiday/es/
@leemannd leemannd force-pushed the 19.0-mig-calendar_public_holiday branch from 13d1fd4 to b5514e7 Compare February 26, 2026 14:54
@leemannd leemannd changed the title 19.0 mig calendar_public_holiday [19.0][MIG]calendar_public_holiday Feb 26, 2026
Copy link
Copy Markdown

@cuongnmtm cuongnmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM. Not much change.

@cuongnmtm
Copy link
Copy Markdown

@leemannd In the PR description, you mention superseds #203 (this PR) instead of #186

@leemannd
Copy link
Copy Markdown
Author

leemannd commented Mar 2, 2026

Hello @OCA/tools-maintainers your review and eventual merge is welcome

@thomaspaulb
Copy link
Copy Markdown

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 19.0-ocabot-merge-pr-203-by-thomaspaulb-bump-nobump, awaiting test results.

@thomaspaulb
Copy link
Copy Markdown

@leemannd Off-topic, but for a customer we are facing the choice of using Odoo's native public holiday functionality or this module. At first glance it was unclear to me what this module adds, do you know?

@OCA-git-bot OCA-git-bot merged commit d5fe9f2 into OCA:19.0 Mar 2, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 84ad106. Thanks a lot for contributing to OCA. ❤️

@leemannd
Copy link
Copy Markdown
Author

leemannd commented Mar 2, 2026

Hello @thomaspaulb we use the OCA module because of the ease of configuration inbewteen years and also because we can setup easily public holidays that are dependent on the state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants