Skip to content

Customization for HLT doublet-recovery tracking iteration with mkFit#48316

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
mmasciov:HLTDRWithMkFit151X
Jun 17, 2025
Merged

Customization for HLT doublet-recovery tracking iteration with mkFit#48316
cmsbuild merged 1 commit intocms-sw:masterfrom
mmasciov:HLTDRWithMkFit151X

Conversation

@mmasciov
Copy link
Copy Markdown
Contributor

PR description:

As per title.
Additionally:

  • cleanup/renaming of customization functions/file;
  • addition of additional customization function to .7 workflows.

PR validation:

Offline is not affected.
HLT validation: https://its.cern.ch/jira/browse/CMSHLT-3566

Backport to 150X will follow

It requires cms-sw/cmsdist#9927

FYI: @mmusich, @missirol, @mtosi, @cms-sw/tracking-pog-l2

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 13, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48316/45187

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mmasciov for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • RecoTracker/MkFit (reconstruction)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @jfernan2, @mandrenguyen, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @gpetruc, @makortel, @missirol, @mmusich, @mtosi, @rovere, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Copy Markdown
Contributor

please test with cms-sw/cmsdist#9927

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddd834/46713/summary.html
COMMIT: 23185eb
CMSSW: CMSSW_15_1_X_2025-06-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48316/46713/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddd834/46713/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddd834/46713/git-merge-result

Comparison Summary

Summary:

@jfernan2
Copy link
Copy Markdown
Contributor

+1

@jfernan2
Copy link
Copy Markdown
Contributor

@mmasciov
Copy link
Copy Markdown
Contributor Author

Hi @jfernan2,

@mmasciov are these differences expected/related? https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_15_1_X_2025-06-13-1100+ddd834/68952/validateJR//12434.7_TTbar_14TeV+2023_trackingMkFit/all_RECO_step3

We may expect slight changes in the .7 workflows for trigger results.
Other changes are unrelated to this PR and to the mkFit-related update from cms-sw/cmsdist#9927. In fact, these changes are almost at the level of "noise" (IIUC, there's a difference of 1 track, which doesn't seem to be directly related to this PR).

process.hltIter0PFlowTrackCutClassifierSerialSync.mva.maxChi2 = cms.vdouble( 999.0, 25.0, 99.0 )
process.hltIter0PFlowTrackCutClassifierSerialSync.mva.maxChi2n = cms.vdouble( 1.2, 1.0, 999.0 )
process.hltIter0PFlowTrackCutClassifierSerialSync.mva.maxChi2 = cms.vdouble( 999.0, 999.0, 99.0 )
process.hltIter0PFlowTrackCutClassifierSerialSync.mva.maxChi2n = cms.vdouble( 999.0, 999.0, 999.0 )
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you change this maxChi2 on purpose?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because of the oddity in the previous configuration:
namely this module is defining three working points, (loose, tight, high-purity (HP)); at HLT, only HP is really used, so the first two values are not actually used. However, I found that for future reference it would be best to avoid quoting tighter cuts for looser WPs (even if unused).

Comment on lines +282 to +286
d0err = cms.vdouble( 0.003, 0.003, 0.003 ),
dr_par1 = cms.vdouble( 3.40282346639E38, 0.45, 0.45 ),
dr_par2 = cms.vdouble( 3.40282346639E38, 0.34, 0.34 ),
dr_exp = cms.vint32( 4, 4, 4 ),
d0err_par = cms.vdouble( 0.001, 0.001, 0.001 )
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my knowledge, is there a reference for these hardcoded numbers?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A search on GitHub will return multiple variants/combinations of cuts, following different optimizations (at multiple points in time).
For reference, these parameters are used (some in a convoluted way) in: https://github.com/cms-sw/cmssw/blob/master/RecoTracker/FinalTrackSelectors/plugins/TrackCutClassifier.cc#L162

@Moanwar
Copy link
Copy Markdown
Contributor

Moanwar commented Jun 16, 2025

+Upgrade

@AdrianoDee
Copy link
Copy Markdown
Contributor

+pdmv

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 036d3c8 into cms-sw:master Jun 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants