Customization for HLT doublet-recovery tracking iteration with mkFit#48316
Customization for HLT doublet-recovery tracking iteration with mkFit#48316cmsbuild merged 1 commit intocms-sw:masterfrom
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48316/45187
|
|
A new Pull Request was created by @mmasciov for master. It involves the following packages:
@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @jfernan2, @mandrenguyen, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test with cms-sw/cmsdist#9927 |
|
+1 Size: This PR adds an extra 40KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
+1 |
|
Hi @jfernan2,
We may expect slight changes in the .7 workflows for trigger results. |
| process.hltIter0PFlowTrackCutClassifierSerialSync.mva.maxChi2 = cms.vdouble( 999.0, 25.0, 99.0 ) | ||
| process.hltIter0PFlowTrackCutClassifierSerialSync.mva.maxChi2n = cms.vdouble( 1.2, 1.0, 999.0 ) | ||
| process.hltIter0PFlowTrackCutClassifierSerialSync.mva.maxChi2 = cms.vdouble( 999.0, 999.0, 99.0 ) | ||
| process.hltIter0PFlowTrackCutClassifierSerialSync.mva.maxChi2n = cms.vdouble( 999.0, 999.0, 999.0 ) |
There was a problem hiding this comment.
Did you change this maxChi2 on purpose?
There was a problem hiding this comment.
Yes, because of the oddity in the previous configuration:
namely this module is defining three working points, (loose, tight, high-purity (HP)); at HLT, only HP is really used, so the first two values are not actually used. However, I found that for future reference it would be best to avoid quoting tighter cuts for looser WPs (even if unused).
| d0err = cms.vdouble( 0.003, 0.003, 0.003 ), | ||
| dr_par1 = cms.vdouble( 3.40282346639E38, 0.45, 0.45 ), | ||
| dr_par2 = cms.vdouble( 3.40282346639E38, 0.34, 0.34 ), | ||
| dr_exp = cms.vint32( 4, 4, 4 ), | ||
| d0err_par = cms.vdouble( 0.001, 0.001, 0.001 ) |
There was a problem hiding this comment.
Just for my knowledge, is there a reference for these hardcoded numbers?
There was a problem hiding this comment.
A search on GitHub will return multiple variants/combinations of cuts, following different optimizations (at multiple points in time).
For reference, these parameters are used (some in a convoluted way) in: https://github.com/cms-sw/cmssw/blob/master/RecoTracker/FinalTrackSelectors/plugins/TrackCutClassifier.cc#L162
|
+Upgrade |
|
+pdmv |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
As per title.
Additionally:
PR validation:
Offline is not affected.
HLT validation: https://its.cern.ch/jira/browse/CMSHLT-3566
Backport to 150X will follow
It requires cms-sw/cmsdist#9927
FYI: @mmusich, @missirol, @mtosi, @cms-sw/tracking-pog-l2