Pixelimage morphing by Chirayu18 · Pull Request #48343 · cms-sw/cmssw

Chirayu18 · 2025-06-17T12:05:23Z

PR description:
This PR implements a new data format for the clustering algorithm for the pixel digis. The new data format is a densely populated 2D image as compared to the 1D sparsely populated digi_view. Also this PR can optionally apply the morphing algorithm for adding fake digis before doing the clustering. This morphing feature proceeds with a dilation step followed by an erosion. In the config these kernels are defined as a 1D array which store the matrix elements for the 3x3 kernels. The following options can now be set in the EDProducer config.:
DoDigiMorphing = cms.bool(True), #Default False
DigiMorphing = cms.PSet(
kernel1 = cms.vint32(1, 1, 1, 1,1,1,1,1,1), # Example kernel values for the dilation kernel
kernel2 = cms.vint32(0, 1, 0, 1,1,1,0,1,1), # Example kernel values for the erosion kernel
)

Implementation details:

SiPixelMorphing.cc defined for storing configuration of morphing parameters
Two ImageSoA’s types are now available and depending on the doDigiMorphing flag, either one is used. For no morphing, the SoA with single layer padding is used and for morphing, 2 layer padding. This saves memory consumption in case morphing is disabled
The makePhase1ClustersAsync function is now templated with ImageType and TrackerTraits(default) and all templated function definitions are defined in SiPixelRawToClusterKernel.dev.cc file
The templated Image is passed to the FindClus kernel which is also templated with ImageType

PR validation:
The code compiles. Comparisions with the legacy CPU code and the current GPU code were also made here: https://indico.cern.ch/event/1555234/contributions/6567409/attachments/3087292/5466320/digimorphing_2%20(1).pdf

cmsbuild · 2025-06-17T12:05:46Z

cms-bot internal usage

cmsbuild · 2025-06-17T12:08:51Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48343/45226

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/PixelClustering.h modified in PR(s): My new feature #48320
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToClusterKernel.dev.cc modified in PR(s): A More Flexible And Lightweight CA #47611, My new feature #48320

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48343/45226/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48343/45226/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2025-06-17T12:18:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48343/45227

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/PixelClustering.h modified in PR(s): My new feature #48320
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToClusterKernel.dev.cc modified in PR(s): A More Flexible And Lightweight CA #47611, My new feature #48320

cmsbuild · 2025-06-17T12:18:42Z

A new Pull Request was created by @Chirayu18 for master.

It involves the following packages:

RecoLocalTracker/SiPixelClusterizer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dkotlins, @felicepantaleo, @ferencek, @gpetruc, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @threus, @tsusa, @tvami this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2025-07-16T07:59:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48343/45518

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToCluster.cc modified in PR(s): Updated SoA View accessors from raw pointers to span #48377
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToClusterKernel.dev.cc modified in PR(s): Updated SoA View accessors from raw pointers to span #48377

cmsbuild · 2025-07-16T07:59:33Z

Pull request #48343 was updated. @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen can you please check and sign again.

fwyzard · 2025-07-16T08:15:46Z

please test

… streams

cmsbuild · 2025-07-17T14:27:48Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48343/45529

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelClusterizer/plugins/BuildFile.xml modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToCluster.cc modified in PR(s): Updated SoA View accessors from raw pointers to span #48377
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToClusterKernel.dev.cc modified in PR(s): Updated SoA View accessors from raw pointers to span #48377

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48343/45529/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48343/45529/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly

cmsbuild · 2025-07-21T11:21:29Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48343/45553

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelClusterizer/plugins/BuildFile.xml modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToCluster.cc modified in PR(s): Updated SoA View accessors from raw pointers to span #48377
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToClusterKernel.dev.cc modified in PR(s): Updated SoA View accessors from raw pointers to span #48377

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48343/45553/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48343/45553/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly

fwyzard · 2025-07-27T16:35:52Z

            alpaka::syncBlockThreads(acc);

-            for (uint32_t i : cms::alpakatools::independent_group_elements(acc, firstPixel, lastPixel - 1)) {
+            alpaka::syncBlockThreads(acc);


you don;t need to syncBlockThreads one after the other

Suggested change

alpaka::syncBlockThreads(acc);

Yes, will commit this change

fwyzard · 2025-07-27T16:38:13Z

+          for (uint32_t j : cms::alpakatools::independent_group_elements(acc, morphingsize)) {
+            uint16_t row = j / (pixelStatus::pixelSizeY + 2) + 1;
+            uint16_t col = j % (pixelStatus::pixelSizeY + 2) + 1;
+            for (int i = 0; i < 3 && image.clus()[col][row] == pixelStatus::fakeVal; i++) {


shouldn't this be

Suggested change

for (int i = 0; i < 3 && image.clus()[col][row] == pixelStatus::fakeVal; i++) {

if (image.clus()[col][row] != pixelStatus::fakeVal) {

continue;

}

for (int i = 0; i < 3; i++) {

otherwise the case i = 0 is performed also for the non-fake pixels.

Yes, will commit this change

fwyzard · 2025-07-27T16:40:15Z

+          for (uint32_t j : cms::alpakatools::independent_group_elements(acc, morphingsize)) {
+            uint16_t row = j / (pixelStatus::pixelSizeY + 2) + 1;
+            uint16_t col = j % (pixelStatus::pixelSizeY + 2) + 1;
+            for (int i = 0; i < 3 && image.clus()[col][row] == pixelStatus::empVal; i++) {


I think this should be

Suggested change

for (int i = 0; i < 3 && image.clus()[col][row] == pixelStatus::empVal; i++) {

if (image.clus()[col][row] != pixelStatus::empVal) {

continue;

}

for (int i = 0; i < 3 && image.clus()[col][row] == pixelStatus::empVal; i++) {

?

Yes indeed. I missed the i=0 cases

fwyzard · 2025-08-22T15:15:55Z

I assume this should be closed in favour of #48734 ?

fwyzard · 2025-08-22T15:18:08Z

-heterogeneous

Assuming this should be superseded by #48734.

cmsbuild · 2025-09-10T06:56:08Z

Milestone for this pull request has been moved to CMSSW_16_0_X. Please open a backport if it should also go in to CMSSW_15_1_X.

mmusich · 2025-10-31T11:22:52Z

@cmsbuild, please close

Chirayu18 and others added 9 commits April 10, 2025 01:26

Converted Sparse Digi Collection to Dense

019acc2

Added clustering and morphing

cde2c51

Fixed Seg Fault

a5a761e

Fixed issues and added atomicCas

9543e27

Cleaned up code

39c70f1

Added clustering with padding the image, so that edges are clustered

b09e44c

Enabled morphing with 2 padding for edges

72f039e

Major code ravamp: Made things configurable and fixed erosion

6b54be1

Added new SoA

e16606c

Chirayu18 marked this pull request as ready for review June 17, 2025 12:05

cmsbuild added this to the CMSSW_15_1_X milestone Jun 17, 2025

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending trk labels Jun 17, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 17, 2025

Chirayu18 marked this pull request as draft June 17, 2025 12:12

Fix code check issues

94f1394

Chirayu18 marked this pull request as ready for review June 17, 2025 12:17

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 17, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 17, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 16, 2025

Chirayu18 added 4 commits July 17, 2025 08:38

Merge branch 'pixelimage_morphing' into pixelimage_rmorphing

0c5560a

Fixed merge issues

e4d28e1

Moved initialization to beginRun to fix race conditions with multiple…

2c9a552

… streams

Code formatted

14a6074

cmsbuild mentioned this pull request Jul 19, 2025

Improve the Phase-1 pixel raw to cluster #48580

Merged

Updated regional morphing modules

73c9347

cmsbuild mentioned this pull request Jul 23, 2025

Restore removal of all duplicate pixel hits in Phase-1 pixel raw to cluster #48609

Merged

fwyzard reviewed Jul 27, 2025

View reviewed changes

cmsbuild mentioned this pull request Jul 28, 2025

Improve the Phase 1 pixel raw to cluster (part 2) #48644

Merged

Chirayu18 mentioned this pull request Aug 14, 2025

Digi Morphing for HLT #48734

Merged

cmsbuild mentioned this pull request Aug 24, 2025

SiStripClusterizer, an Alpaka port of the CUDA ClustersFromRawProducerGPU #47629

Merged

This was referenced Sep 2, 2025

[15_0_X] Digi Morphing for HLT #48831

Closed

[15_0_X] Digi Morphing for HLT #48832

Merged

cmsbuild mentioned this pull request Sep 10, 2025

silence SiPixelRawToCluster verbose ROC and FED error printouts (again) #48890

Merged

cmsbuild mentioned this pull request Sep 29, 2025

Fixes for Digi Morphing: Limiting Histogram Size and Decoupling for TrackerTraits #49021

Merged

cmsbuild mentioned this pull request Oct 13, 2025

Clamp fakePixels to maxFakesInModule #49142

Merged

cmsbuild mentioned this pull request Oct 31, 2025

[NGT] Add support for older geometries in PixelTracking CA #49272

Merged

-            for (int i = 0; i < 3 && image.clus()[col][row] == pixelStatus::fakeVal; i++) {
+            if (image.clus()[col][row] != pixelStatus::fakeVal) {
+              continue;
+            }
+            for (int i = 0; i < 3; i++) {

Conversation

Chirayu18 commented Jun 17, 2025

Uh oh!

cmsbuild commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jun 17, 2025

Uh oh!

cmsbuild commented Jun 17, 2025

Uh oh!

cmsbuild commented Jun 17, 2025

Uh oh!

cmsbuild commented Jul 16, 2025

Uh oh!

cmsbuild commented Jul 16, 2025

Uh oh!

fwyzard commented Jul 16, 2025

Uh oh!

cmsbuild commented Jul 17, 2025

Uh oh!

cmsbuild commented Jul 21, 2025

Uh oh!

fwyzard Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

Chirayu18 Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

fwyzard Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

fwyzard Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

Chirayu18 Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

fwyzard Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

Chirayu18 Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

fwyzard commented Aug 22, 2025

Uh oh!

fwyzard commented Aug 22, 2025

Uh oh!

cmsbuild commented Sep 10, 2025

Uh oh!

mmusich commented Oct 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cmsbuild commented Jun 17, 2025 •

edited

Loading