add HLT vertexing resolution monitoring (by split vertex method)#48980
add HLT vertexing resolution monitoring (by split vertex method)#48980cmsbuild merged 1 commit intocms-sw:masterfrom
Conversation
|
@cmsbuild ping |
|
@mmusich cmsrep (which receives github webhook requests for cms-bot to run) is overloaded, I'm trying to fix it. |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48980/46160
|
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
@cmsbuild, please test |
|
-1 Failed Tests: RelVals RelVals
|
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
Is this all due to the new sequences? PS: This is offline only, right? |
yes.
right. |
@LinaresToine Could we request your input on this increase, from the T0 side? Will this create a problem? |
|
Thanks for your question @nothingface0. The memory problem is already there, however, with dqm harvesting jobs using 3 GB we have managed to reduce the number of paused jobs to around 1 per week. This tells me that a 4% increment should not make the existing problem a much bigger one. Nonetheless, I do like to ask not to push much further |
I think there is a misunderstanding here. At Tier0 this PR would change only the DQM sequence for the |
|
Right @mmusich |
|
+dqm
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
@mmusich It looks like this PR is causing some IB crashes in heavy-ion workflows. Would you please have a look? |
A proper fix would require a HLT menu update (to be discussed elsewhere). I can prepare a patch to overcome the issue, likely tomorrow. |
Sounds good, thanks. |
done at #49014. |
PR description:
Add HLT vertexing resolution monitoring (using the "split vertex" method) for all the vertex types available at HLT (in both Run 3 and Phase-2).
This leverages the existing module
PrimaryVertexResolution(which is lightly adapted to tolerate events in which the input colections are missing) and changes the configuration of both theDQMandHarvestingsteps to be run in the@HLTMonsequence.PR validation:
Run successfully both a run3 and phase-2 workflow (running non-trivial HLT menus)
and checked that the output files have the expected output in terms of monitor elements.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, will be backported to CMSSW_15_0_X for testing in the 2025 data-taking release.