PrimaryVertexResolution: add protection against missing track references in input vertex

[mmusich]

resolves #49018

PR description:

Title says it all, workaround for #48980 (comment).
The proper fix would consist in making sure the constituent tracks of an HLT vertex are saved as output of the HIon HLT menu. This will be follow-up with a ticket CMSHLT (analogous to CMSHLT-3618 that was done to supply the same for the pp menu GRun)
Whenever the input vertex misses the references to constituent tracks, skip the processing and emit a warning (once per job).
The logic is the same as in

cmssw/DQMOffline/RecoB/plugins/PrimaryVertexMonitor.cc

Lines 415 to 435 in 4ddd889

	// check upfront that refs to track are (likely) to be valid
	{
	bool ok = true;
	for (const auto& v : *recVtxs) {
	if (v.tracksSize() > 0) {
	const auto& ref = v.trackRefAt(0);
	if (ref.isNull() || !ref.isAvailable()) {
	if (!errorPrinted_)
	edm::LogWarning("PrimaryVertexMonitor")
	<< "Skipping vertex collection: " << vertexInputTag_
	<< " since likely the track collection the vertex has refs pointing to is missing (at least the first "
	"TrackBaseRef is null or not available)";
	else
	errorPrinted_ = true;
	ok = false;
	}
	}
	}
	if (!ok)
	return;
	}

PR validation:

runTheMatrix.py -l 161.4 -t 4 -j 8 -i all --ibeos runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[mmusich]

@cmsbuild ping

[cmsbuild]

cms-bot internal usage

[mmusich]

test parameters:

• workflow = 161.4

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49014/46204

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• DQM/TrackingMonitor (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@VinInn, @VourMa, @arossi83, @elusian, @fioriNTU, @idebruyn, @jandrea, @mmasciov, @mmusich, @mtosi, @richa2710, @sroychow, @threus this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8bd7d/48316/summary.html
COMMIT: f88e74b
CMSSW: CMSSW_16_0_X_2025-09-28-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49014/48316/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 2024.0070001DAS Error
• 2025.0000001DAS Error

RelVals-INPUT

• 2024.0060001DAS Error

[mmusich]

test parameters:

• workflows = 161,161.02,161.03,161.1,161.2,161.3,161.4,162,162.02,162.03,162.1,162.2,162.3,162.4

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: RelVals
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8bd7d/48318/summary.html
COMMIT: f88e74b
CMSSW: CMSSW_16_0_X_2025-09-28-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49014/48318/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 2024.0070001DAS Error
• 2025.0000001DAS Error
• 2024.0050001DAS Error

[mmusich]

urgent

• to fix IB failures

[mandrenguyen]

There's a lot of DAS errors in similar workflows since the afternoon of Sept 22nd, but I'm not easily seeing where this is coming from.

[mmusich]

There's a lot of DAS errors in similar workflows since the afternoon of Sept 22nd, but I'm not easily seeing where this is coming from.

My guess is that it's coming from #48490 (@cms-sw/pdmv-l2 FYI).

[gabrielmscampos]

Hi @mmusich, what does this command do please ignore tests-rejected with external-failure? Does it forcefully mark the tests as passed?

The code looks fine, I can sign it. However, without the Comparison Summary from the succeeded tests, I can't do all the checks stated in the DQM instructions. A retry makes sense to get the test results?

[mmusich]

@gabrielmscampos

Does it forcefully mark the tests as passed?

yes.

A retry makes sense to get the test results?

I am not sure. See #49014 (comment).
Also please keep in mind this PR is marked as urgent.

[gabrielmscampos]

+dqm

• RelVal tests skipped due to DAS errors

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

@cmsbuild, please test

• just to give an extra trial

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8bd7d/48328/summary.html
COMMIT: f88e74b
CMSSW: CMSSW_16_0_X_2025-09-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49014/48328/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
161.02 step 4
161.0 step 3
161.1 step 3
161.2 step 3
161.3 step 3
161.4 step 3
2024.0050001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 114 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 58
• DQMHistoTests: Total histograms compared: 4869533
• DQMHistoTests: Total failures: 44
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4869469
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 57 files compared)
• Checked 278 log files, 254 edm output root files, 58 DQM output files
• TriggerResults: no differences found

[ftenchini]

+1