Modernization of TrackToTrackComparisonHists

[mmusich]

PR description:

Technical no regressions expected:

• merge header with implementation (as expected for a plugin)
• use range-based loop when possible
• reduced cost of fillMap by using deltaR2 vs deltaR
• simplified logic of event data retrieval

PR validation:

runTheMatrix.py -l 18634.0 -t 4 -j 8 -i all --ibeos runs.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49913/47656

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DQM/TrackingMonitorSource/interface/TrackToTrackComparisonHists.h modified in PR(s): CPU vs. GPU for LST in HLT and updates to the offline #49832
  • File DQM/TrackingMonitorSource/src/TrackToTrackComparisonHists.cc modified in PR(s): CPU vs. GPU for LST in HLT and updates to the offline #49832

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• DQM/TrackingMonitorSource (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@VinInn, @VourMa, @arossi83, @elusian, @fioriNTU, @idebruyn, @jandrea, @mmasciov, @mmusich, @mtosi, @richa2710, @sroychow, @threus this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e42137/50843/summary.html
COMMIT: 85f9f89
CMSSW: CMSSW_16_1_X_2026-01-23-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49913/50843/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 54
• DQMHistoTests: Total histograms compared: 4258941
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4258918
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
• Checked 230 log files, 203 edm output root files, 54 DQM output files
• TriggerResults: no differences found

[nothingface0]

+dqm

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[ftenchini]

+1