CloseBy smearing for Phase-1. by bfonta · Pull Request #50225 · cms-sw/cmssw

bfonta · 2026-02-23T14:02:42Z

Follows #49584, which only considered Phase-2 workflows, via GenSimHLBeamSpotCloseBy. This PR adds the GenSimCloseBy step.
I've avoided some code duplication when most of the options of several steps are identical.

PR validation:

Note the --beamspot CloseBy option.

Phase-2:

$ runTheMatrix.py -w upgrade -el 34553.0 --show                      
(...)

34553.0 CloseByPGun_Barrel_Front_Run4D121_GenSimHLBeamSpotCloseBy+DigiTrigger_Run4D121+RecoGlobal_Run4D121+HARVESTGlobal_Run4D121+ALCAPhase2_Run4D121 [1]: cmsDriver.py Close
ByPGun_Barrel_Front_cfi  -s GEN,SIM -n 10 --conditions auto:phase2_realistic_T35 --beamspot CloseBy --datatier GEN-SIM --eventcontent FEVTDEBUG --geometry ExtendedRun4D121 -
-era Phase2C22I13M9 --relval 9000,100 
                                           [2]: cmsDriver.py step2  -s DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:@relvalRun4 --conditions auto:phase2_realistic_
T35 --datatier GEN-SIM-DIGI-RAW -n 10 --eventcontent FEVTDEBUGHLT --geometry ExtendedRun4D121 --era Phase2C22I13M9
                                           [3]: cmsDriver.py step3  -s RAW2DIGI,RECO,RECOSIM,PAT,VALIDATION:@phase2Validation+@miniAODValidation,DQM:@phase2+@miniAODDQM --co
nditions auto:phase2_realistic_T35 --datatier GEN-SIM-RECO,MINIAODSIM,DQMIO -n 10 --eventcontent FEVTDEBUGHLT,MINIAODSIM,DQM --geometry ExtendedRun4D121 --era Phase2C22I13M9
                                           [4]: cmsDriver.py step4  -s HARVESTING:@phase2Validation+@phase2+@miniAODValidation+@miniAODDQM --conditions auto:phase2_realistic
_T35 --mc  --geometry ExtendedRun4D121 --scenario pp --filetype DQM --era Phase2C22I13M9 -n 100 
                                           [5]: cmsDriver.py step5  -s ALCA:SiPixelCalSingleMuonLoose+SiPixelCalSingleMuonTight+TkAlMuonIsolated+TkAlMinBias+MuAlOverlaps+Eca
lESAlign+TkAlZMuMu+TkAlDiMuonAndVertex+HcalCalHBHEMuonProducerFilter+TkAlUpsilonMuMu+TkAlJpsiMuMu --conditions auto:phase2_realistic_T35 --datatier ALCARECO -n 10 --eventcon
tent ALCARECO --geometry ExtendedRun4D121 --era Phase2C22I13M9

1 workflows with 5 steps

Run-3:

 $ runTheMatrix.py -w upgrade -el 34553.0 --show                      
(...)                                                                                                                   
                                                                                                                                                                             
16953.0 CloseByPGun_Barrel_Front_2025_GenSimCloseBy+Digi_2025+RecoNanoFakeHLT_2025+HARVESTNanoFakeHLT_2025+ALCA_2025 [1]: cmsDriver.py CloseByPGun_Barrel_Front_cfi  -s GEN,SIM -n 10 --conditions auto:phase1_2025_realistic --beamspot CloseBy --datatier GEN-SIM --eventcontent FEVTDEBUG --geometry DB:Extended --era Run3_2025 --relval 9000,100 
                                           [2]: cmsDriver.py step2  -s DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval2025 --conditions auto:phase1_2025_realistic --datatier GEN-SIM-DIGI-RAW -n 10 --eventcontent FEVTDEBUGHLT --geometry DB:Extended --era Run3_2025
                                           [3]: cmsDriver.py step3  -s RAW2DIGI,L1Reco,RECO,RECOSIM,PAT,NANO,VALIDATION:@standardValidationNoHLT+@miniAODValidation,DQM:@standardDQMFakeHLT+@miniAODDQM+@nanoAODDQM --conditions auto:phase1_2025_realistic --datatier GEN-SIM-RECO,MINIAODSIM,NANOAODSIM,DQMIO -n 10 --eventcontent RECOSIM,MINIAODSIM,NANOEDMAODSIM,DQM --geometry DB:Extended --era Run3_2025
                                           [4]: cmsDriver.py step4  -s HARVESTING:@standardValidationNoHLT+@standardDQMFakeHLT+@miniAODValidation+@miniAODDQM+@nanoAODDQM --conditions auto:phase1_2025_realistic --mc  --geometry DB:Extended --scenario pp --filetype DQM --era Run3_2025 -n 100 
                                           [5]: cmsDriver.py step5  -s ALCA:SiPixelCalSingleMuonLoose+SiPixelCalSingleMuonTight+TkAlMuonIsolated+TkAlMinBias+MuAlOverlaps+EcalESAlign+TkAlZMuMu+TkAlDiMuonAndVertex+HcalCalHBHEMuonProducerFilter+TkAlUpsilonMuMu+TkAlJpsiMuMu+SiStripCalMinBias --conditions auto:phase1_2025_realistic --datatier ALCARECO -n 10 --eventcontent ALCARECO --geometry DB:Extended --era Run3_2025

Both workflows are now using IOMC.EventVertexGenerators.VtxSmearedCloseBy_cfi.

bfonta · 2026-02-23T14:02:51Z

type ngt

cmsbuild · 2026-02-23T14:03:08Z

cms-bot internal usage

cmsbuild · 2026-02-23T14:04:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50225/48205

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Update defaultDataSets for D121 and D110 #50036, Fix PbPb relvals #50222
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): update phase-2 HLT timing script and use alpaka modifier in NGT workflows #49821, Fix: remove dependencies of trackingNutple sequence for phase-2 HLT #49857, TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932, Switch to the new tracking baseline (single iteration, CA-extended Patatrack + LST, mkFit) as Phase 2 HLT default #50040

cmsbuild · 2026-02-23T14:04:55Z

A new Pull Request was created by @bfonta for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv)

@AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @miquork can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2026-02-23T16:25:23Z

test parameters:

relval_opts = -w upgrade
workflows = 16953.0, 34553.0

mmusich · 2026-02-23T16:25:30Z

@cmsbuild, please test

cmsbuild · 2026-02-23T22:11:19Z

+1

Size: This PR adds an extra 92KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b9eef/51525/summary.html
COMMIT: 3cf4641
CMSSW: CMSSW_16_1_X_2026-02-23-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50225/51525/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially added 10 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 33590 differences found in the comparisons
DQMHistoTests: Total files compared: 55
DQMHistoTests: Total histograms compared: 4428933
DQMHistoTests: Total failures: 234233
DQMHistoTests: Total nulls: 10
DQMHistoTests: Total successes: 4194670
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 7.207000000000001 KiB( 54 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.117 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): -1.050 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 17034.0 ): 5.581 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 18634.0 ): 2.559 KiB SiStrip/MechanicalView
Checked 237 log files, 207 edm output root files, 55 DQM output files
TriggerResults: found differences in 10 / 53 workflows

Max Memory Comparisons exceeding threshold

@cms-sw/core-l2 , I found 5 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...

Error: Workflow 12834.0_TTbar_14TeV+2024 step5 max memory diff 390.9 exceeds +/- 90.0 MiB
Error: Workflow 13034.0_TTbar_14TeV+2024PU step3 max memory diff 214.6 exceeds +/- 90.0 MiB
Error: Workflow 13034.0_TTbar_14TeV+2024PU step2 max memory diff 278.8 exceeds +/- 90.0 MiB
Error: Workflow 16834.0_TTbar_14TeV+2025 step5 max memory diff 391.2 exceeds +/- 90.0 MiB
Error: Workflow 18434.0_TTbar_14TeV+2026 step5 max memory diff -333.4 exceeds +/- 90.0 MiB

mmusich · 2026-02-23T22:13:37Z

DQMHistoTests: Total failures: 234233

Something is very wrong in this PR

cmsbuild · 2026-02-24T16:04:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50225/48234

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Update defaultDataSets for D121 and D110 #50036, Fix PbPb relvals #50222
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): update phase-2 HLT timing script and use alpaka modifier in NGT workflows #49821, TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932, Switch to the new tracking baseline (single iteration, CA-extended Patatrack + LST, mkFit) as Phase 2 HLT default #50040

cmsbuild · 2026-02-25T15:07:29Z

Pull request #50225 was updated. @AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @miquork can you please check and sign again.

mmusich · 2026-02-25T15:08:19Z

@cmsbuild, please test

cmsbuild · 2026-02-25T17:15:05Z

+1

Size: This PR adds an extra 124KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b9eef/51596/summary.html
COMMIT: 2f92fda
CMSSW: CMSSW_16_1_X_2026-02-25-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50225/51596/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially added 3 lines to the logs
Reco comparison results: 899 differences found in the comparisons
DQMHistoTests: Total files compared: 55
DQMHistoTests: Total histograms compared: 4429509
DQMHistoTests: Total failures: 508
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4428981
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
Checked 237 log files, 207 edm output root files, 55 DQM output files
TriggerResults: found differences in 1 / 53 workflows

AdrianoDee · 2026-03-03T17:54:11Z

+pdmv

cmsbuild · 2026-03-03T17:54:34Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2026-03-03T19:43:08Z

+1

cmsbuild added this to the CMSSW_16_1_X milestone Feb 23, 2026

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending code-checks-pending ngt labels Feb 23, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 23, 2026

cmsbuild added tests-started and removed tests-pending labels Feb 23, 2026

cmsbuild added tests-approved and removed tests-started labels Feb 23, 2026

Enable CloseBy smearing for Phase 1.

c98075f

bfonta force-pushed the run3_closeby_smearing branch from 3cf4641 to c98075f Compare February 24, 2026 16:02

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Feb 24, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 24, 2026

cmsbuild added tests-started and removed tests-pending labels Feb 25, 2026

cmsbuild added tests-approved and removed tests-started labels Feb 25, 2026

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Mar 3, 2026

cmsbuild added orp-approved and removed orp-pending labels Mar 3, 2026

cmsbuild merged commit 38ea90e into cms-sw:master Mar 3, 2026
11 checks passed

Conversation

bfonta commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bfonta commented Feb 23, 2026

Uh oh!

cmsbuild commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 23, 2026

Uh oh!

cmsbuild commented Feb 23, 2026

Uh oh!

mmusich commented Feb 23, 2026

Uh oh!

mmusich commented Feb 23, 2026

Uh oh!

cmsbuild commented Feb 23, 2026

Comparison Summary

Max Memory Comparisons exceeding threshold

Uh oh!

mmusich commented Feb 23, 2026

Uh oh!

cmsbuild commented Feb 24, 2026

Uh oh!

cmsbuild commented Feb 25, 2026

Uh oh!

mmusich commented Feb 25, 2026

Uh oh!

cmsbuild commented Feb 25, 2026

Comparison Summary

Uh oh!

AdrianoDee commented Mar 3, 2026

Uh oh!

cmsbuild commented Mar 3, 2026

Uh oh!

mandrenguyen commented Mar 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bfonta commented Feb 23, 2026 •

edited

Loading

cmsbuild commented Feb 23, 2026 •

edited

Loading