Merged
Conversation
Test this pull request
|
This was referenced Mar 19, 2026
15 tasks
cyaiox
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new physics controller interface and adds support for spring bone parameters in the preview system. It defines a new
SpringBoneParamstype with validation, updates the preview messaging protocol to handle physics-related requests, and includes tests for the new type.Preview system enhancements:
IPhysicsControllerinterface topreview-controller.tsand exposed it inIPreviewController, enabling physics-related operations in the preview API. (src/dapps/preview/preview-controller.ts, [1] [2] [3]physicsnamespace and thesetSpringBonesParamsmethod, allowing spring bone parameters to be set via controller requests. (src/dapps/preview/preview-message.ts, [1] [2] [3]Spring bone parameters implementation:
SpringBoneParamstype and its validation schema, including constraints for each parameter and an optionalcenterfield. (src/dapps/preview/spring-bone-params.ts, [1] [2]spring-bone-paramsfrom the preview module for external usage. (src/dapps/preview/index.ts, src/dapps/preview/index.tsR10)Testing:
SpringBoneParams, covering validation logic and boundary cases. (test/dapps/preview/spring-bone-params.spec.ts, test/dapps/preview/spring-bone-params.spec.tsR1-R52)Related PRs: