Skip to content

feat: spring bones#416

Merged
RocioCM merged 3 commits intomainfrom
feat/spring-bones
Mar 26, 2026
Merged

feat: spring bones#416
RocioCM merged 3 commits intomainfrom
feat/spring-bones

Conversation

@RocioCM
Copy link
Copy Markdown
Member

@RocioCM RocioCM commented Mar 19, 2026

This pull request introduces a new physics controller interface and adds support for spring bone parameters in the preview system. It defines a new SpringBoneParams type with validation, updates the preview messaging protocol to handle physics-related requests, and includes tests for the new type.

Preview system enhancements:

  • Added IPhysicsController interface to preview-controller.ts and exposed it in IPreviewController, enabling physics-related operations in the preview API. (src/dapps/preview/preview-controller.ts, [1] [2] [3]
  • Updated the preview messaging protocol to support the new physics namespace and the setSpringBonesParams method, allowing spring bone parameters to be set via controller requests. (src/dapps/preview/preview-message.ts, [1] [2] [3]

Spring bone parameters implementation:

  • Introduced the SpringBoneParams type and its validation schema, including constraints for each parameter and an optional center field. (src/dapps/preview/spring-bone-params.ts, [1] [2]
  • Exported spring-bone-params from the preview module for external usage. (src/dapps/preview/index.ts, src/dapps/preview/index.tsR10)

Testing:

Related PRs:

@RocioCM RocioCM self-assigned this Mar 19, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

Test this pull request

  • The package can be tested by running
    npm upgrade "https://sdk-team-cdn.decentraland.org/@dcl/schemas/branch/feat/spring-bones/dcl-schemas-25.2.1-23596466413.commit-a173994.tgz"

@RocioCM RocioCM changed the title [WIP] feat: spring bones feat: spring bones [WIP] Mar 19, 2026
@RocioCM RocioCM changed the title feat: spring bones [WIP] feat: spring bones Mar 24, 2026
@RocioCM RocioCM marked this pull request as ready for review March 25, 2026 14:23
@RocioCM RocioCM merged commit 38f11e1 into main Mar 26, 2026
4 checks passed
@RocioCM RocioCM deleted the feat/spring-bones branch March 26, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants