#1685: Added Nest CLI to IDEasy commandlets#1860
Conversation
0c5377c to
4094f2f
Compare
Coverage Report for CI Build 25375856694Coverage increased (+0.03%) to 70.764%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions22 previously-covered lines in 3 files lost coverage.
Coverage Stats💛 - Coveralls |
22cec6a to
ab1f308
Compare
|
@satorus thanks for the review. I also noticed that i forgot to call NestUrlUpdater in updaters in UpdateManager. It should now be corrected. You are correct regarding your comment about the npm version. It may be a bug that we need to check it and fix it. |
@satorus thanks for testing and finding this problem. |
hohwille
left a comment
There was a problem hiding this comment.
@AdemZarrouki thank you very much for your PR. Look like solid and good work to me. 👍
I added some review comments. Please have a look and address them.
Then we can merge this PR.
Sorry, if something things are obvious to me but unclear to (newer) team members.
We should discuss (e.g. in our retro) how to better prevent pointless work like creating an UrlUpdater when not needed.
2fbc910 to
4b1dc24
Compare
2323e68 to
7162792
Compare
# Conflicts: # cli/src/main/java/com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java
…gration in ide-projects
…n IDEasy commandlets # Conflicts: # CHANGELOG.adoc # Conflicts: # CHANGELOG.adoc
…commandlet and documentation
…agerBasedLocalToolCommandlet to avoid infinite loops
9911e6f to
2c7bfe1
Compare
hohwille
left a comment
There was a problem hiding this comment.
@AdemZarrouki great. Now everything is solved and ready for merge 👍


This PR fixes #1685
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalChecklist for tool commandlets
Have you added a new
«tool»as commandlet? There are the following additional checks:«tool»«TOOL»_VERSIONand«TOOL»_EDITIONare honored by your commandlet