chore: coding standards compliance review and test coverage - #845
Draft
cursor[bot] wants to merge 2 commits into
Draft
chore: coding standards compliance review and test coverage#845cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Add regression tests for recently merged high-risk paths: - feature-flag-rollout prompt: dual-mode scope validation (workspaceId vs orgId+projectId) and Harness-native NYI caveat surfacing (#806) - policy/policy_set get/create/update/delete: verify resource_scope account/org/project param injection matches list behavior (#819) - infrastructure deep links: nested environmentRef aliasing and environment_id param fallback when API omits environmentRef (#809) Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Remove unused nativeModeCaveat from feature-flag-rollout prompt now that fme_rollout_status is wired on main (#838). Update harness-native test assertions to match the current prompt text. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Audited the codebase against
docs/coding-standards.mdand verified all automated guardrails pass on latestmain.This PR also rebases and extends the test coverage from #836, with one fix after main landed native FME rollout status support (#838):
policy/policy_set(resource_scopeaccount/org/project)nativeModeCaveatfromfeature-flag-rollout(computed but never appended; obsolete after feat: wire native FME traffic type and rollout status lists #838)Standards review summary
registerTool, no new handlers)architecture.test.tsconsole.loginsrc/)HarnessClientinsrc/index.ts.describe()on tool inputsconfirmoperationPolicyon every endpointNote: Automation snapshots referencing "10 tools", Zod v3, or
server.tool()are outdated. Canonical source isdocs/coding-standards.md(11 tools incl.harness_schema, Zod v4,registerTool()).Type of Change
Checklist
pnpm testpasses (3105 tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpasses (77 tests)pnpm docs:checknot required (no registry/tool count changes)Coding Standards (registry-driven MCP model)
server.registerTool()calls