refactor: extend for-comprehension usage beyond argparse#3445
Closed
refactor: extend for-comprehension usage beyond argparse#3445
Conversation
Apply the same for-comprehension pattern used in required_option_usage to other places where an imperative loop accumulates into an array: - argparse/help_render.mbt: positional_entries, subcommand_entries, group_members - priority_queue: ToJson implementation - bytes regex_engine translate: Alternation arm Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Collaborator
Coverage Report for CI Build 3874Coverage decreased (-0.003%) to 94.911%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This was referenced Apr 20, 2026
Contributor
Author
|
Superseded by #3448 which consolidates all comprehension refactors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3444. Apply the same for-comprehension pattern to other imperative loops that just accumulate into an array:
Skipped candidates where the comprehension would lose an explicit `capacity` pre-alloc hint or where the loop has branching pushes (e.g., `arg_display`, `option_entries`, `positional_usage`, `List::to_json`).
Test plan
🤖 Generated with Claude Code