Skip to content

APP-14871: Add ReportICECandidateSelected to exemptFromConnectionCheck#5853

Open
danielbotros wants to merge 2 commits intoviamrobotics:mainfrom
danielbotros:APP-14871-add-report-candidates-rpc-to-exempt-check
Open

APP-14871: Add ReportICECandidateSelected to exemptFromConnectionCheck#5853
danielbotros wants to merge 2 commits intoviamrobotics:mainfrom
danielbotros:APP-14871-add-report-candidates-rpc-to-exempt-check

Conversation

@danielbotros
Copy link
Copy Markdown
Member

@danielbotros danielbotros commented Mar 16, 2026

Description

APP-14871 Track coturn usage

  • Adds ReportICECandidateSelected to the exemptFromConnectionCheck map in robot/client/client.go
  • This RPC is part of the WebRTC signaling flow and must be callable before a full robot connection is established, similar to Call, CallUpdate, and OptionalWebRTCConfig. It reports the webRTC client candidate pair type to the signaling server.

Testing

  • Verify that ReportICECandidateSelected can be called during the WebRTC signaling handshake without being blocked by the connection check

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Mar 16, 2026
@danielbotros danielbotros marked this pull request as ready for review March 17, 2026 16:22
@danielbotros danielbotros changed the title Add ReportICECandidateSelected to exemptFromConnectionCheck APP-14871: Add ReportICECandidateSelected to exemptFromConnectionCheck Mar 17, 2026
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test This pull request is marked safe to test from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants