FE-845: TUI chrome resolutions pass II by lunelson · Pull Request #203 · hashintel/brunch

lunelson · 2026-06-11T10:09:55Z

Stack Context

This PR continues the FE-845 chrome polish work on top of the Tier-2 introspection branch.

What?

Adds runtime posture slash commands and picker components.
Covers runtime axis/strategy selection in Pi extension and TUI tests.
Connects the runtime state commands to the dev Tier-2 harness.

lunelson · 2026-06-11T10:10:27Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

cursor · 2026-06-11T10:13:45Z

PR Summary

Medium Risk
Changes cross session transcript authority, extension commands, active tool policy, and TUI overlays; mistakes could desync posture from provider turns or append invalid runtime facts.

Overview
Replaces stub /brunch:strategy, /brunch:lens, and /brunch:mode with real Pi extension handlers that validate axis values against shared runtime-state vocabularies, append brunch.agent_runtime_state switch entries (source: user), refresh active tools, and notify the user. No-arg strategy / lens open overlay pickers built on tui-lab segment UI; mode only reports elicit or rejects unsupported values.

Exports OPERATIONAL_MODE_IDS, AGENT_STRATEGY_IDS, and AGENT_LENS_IDS for command validation. Adds unit tests for commands, pickers, and chrome footer lines that prefer projected agentState over launch-time chrome fallbacks, plus a Tier-2 test that runs brunch:lens through a real runBrunchTui boot. Documents the slice in memory/cards/tooling--runtime-state-commands.md.

^{Reviewed by Cursor Bugbot for commit 60451fb. Bugbot is set up for automated code reviews on this repo. Configure here.}

Copilot

Pull request overview

This PR continues FE-845 chrome polish by wiring real runtime posture switching into the Pi extension command surface, adding TUI picker overlays for strategy/lens selection, and extending Tier-2 + unit test coverage to prove the command → transcript runtime state → chrome/tooling projections path.

Changes:

Exported runtime axis vocabularies and implemented /brunch:lens, /brunch:strategy, and /brunch:mode commands (with picker overlays when invoked without args).
Added new runtime posture picker component(s) and associated tests.
Extended Tier-2 harness and chrome/TUI tests to validate runtime switch behavior and chrome footer projection.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/session/runtime-state.ts	Exports runtime axis vocabularies for validation at adapter/command surfaces.
src/dev/tier-2-harness.test.ts	Adds a real-boot test proving the registered runtime switch command path.
src/app/brunch-tui.test.ts	Updates command registration assertions to reflect new non-stub runtime commands.
src/.pi/extensions/commands/index.ts	Implements runtime switch commands and wires them into Brunch command registration.
src/.pi/components/runtime-posture/strategy-picker.ts	Adds a re-export wrapper for the strategy picker component.
src/.pi/components/runtime-posture/axis-picker.ts	Adds the reusable runtime axis picker overlay component used by commands.
src/.pi/tests/support/tui-theme.ts	Introduces a test theme to make ANSI rendering assertions stable.
src/.pi/tests/runtime-switch-command.test.ts	Adds unit tests for runtime switch command validation and entry appending.
src/.pi/tests/runtime-axis-picker.test.ts	Adds unit tests for picker rendering, cycling, and commit/cancel behavior.
src/.pi/tests/chrome.test.ts	Ensures chrome footer prefers projected runtime telemetry over launch-time fallback.
memory/cards/tooling--runtime-state-commands.md	Adds a work card documenting the runtime state command slice and verification approach.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+  appendBrunchAgentRuntimeSwitch(
+    {
+      getEntries: () => ctx.sessionManager.getEntries(),
+      appendCustomEntry: (customType, data) => {
+        pi.appendEntry(customType, data);
+        return '';
+      },
+    },
+    nextState,
+    'user',
+  );


+      if (selection === current.operationalMode) {
+        ctx.ui.notify('Brunch mode is already elicit.', 'info');
+        return;
+      }


+      ctx.ui.notify(
+        'Only elicit mode is available in this Brunch build; execute mode is not implemented.',
+        'error',
+      );


+- Seam: Brunch TUI chrome + Pi extension commands over transcript-backed runtime state (`src/.pi/extensions/{commands,runtime,chrome}` → `src/session/runtime-state.ts` → `src/projections/session/*`).
+- Nearby frontier: this is not yet a named `memory/PLAN.md` frontier; it is FE-845 branch work. It should build on the active lower-stack `dx-tier-2-harness` frontier (`ln/fe-847-dx-introspection-tier-2`) for real-boot/faux-turn proof rather than inventing a local fake harness.
+- Volatile state: user declared Pi update suppression and new-session header recovery sufficiently done; keyboard shortcut lookup overlay and `src/.pi/components/tui-lab/` posture UI experiments are deferred for later implementation, not part of this card.
+- TUI interaction model for this slice: go straight through namespaced slash commands as the first user-facing surface (`/brunch:strategy`, `/brunch:lens`, mode read/no-op). Use notifications/errors for feedback; do not introduce a custom selector/overlay yet.


+Custom TUI controls are explicitly out of scope. The experimental `src/.pi/components/tui-lab/` segment/chip components are promising for a follow-on posture picker or overlay, but this slice should not couple runtime authority to that exploratory UI.
+


+└── explicit non-scope
+    ├── update suppression/header recovery remain treated as already accomplished
+    ├── keyboard shortcut lookup overlay is documented as deferred, not implemented here
+    └── tui-lab posture picker/overlay is deferred to a following slice


+import {
+  AGENT_LENS_IDS,
+  AGENT_STRATEGY_IDS,
+  type AgentLensSelection,
+  type AgentStrategySelection,
+} from '../../../session/runtime-state.js';
+import {
+  nextSegmentIndex,
+  previousSegmentIndex,
+  renderSegmentTrack,
+  safeLines,
+  type LabTheme,
+  type TrackSegment,
+} from '../tui-lab/index.js';
+
+interface Component {
+  render(width: number): string[];
+  handleInput?(data: string): void;
+  invalidate(): void;
+}


cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 61eaa48. Configure here.}

This was referenced Jun 11, 2026

FE-847: DX introspection tier 2 #202

Merged

FE-848: Prompt context refinement #204

Merged

lunelson marked this pull request as ready for review June 11, 2026 10:13

Copilot AI review requested due to automatic review settings June 11, 2026 10:13

Copilot started reviewing on behalf of lunelson June 11, 2026 10:13 View session

lunelson changed the title ~~FE-845: Wire runtime posture slash commands~~ FE-845: TUI chrome resolutions pass II Jun 11, 2026

cursor Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread src/.pi/extensions/commands/index.ts

Copilot AI reviewed Jun 11, 2026

View reviewed changes

lunelson force-pushed the ln/fe-845-brunch-chrome-pass-ii branch from da0360b to b944790 Compare June 11, 2026 14:30

lunelson force-pushed the ln/fe-847-dx-introspection-tier-2 branch from f36df77 to 13c0aca Compare June 11, 2026 14:30

This was referenced Jun 11, 2026

FE-847: DX introspection tier 2 #205

Merged

FE-XXX: Projection coverage orientation and scoping #206

Merged

FE-852: Prompt composition golden coverage and elicitation driver #207

Merged

lunelson force-pushed the ln/fe-845-brunch-chrome-pass-ii branch from b944790 to 61eaa48 Compare June 11, 2026 14:33

lunelson force-pushed the ln/fe-847-dx-introspection-tier-2 branch from 13c0aca to 50e5001 Compare June 11, 2026 14:33

cursor Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread src/.pi/extensions/commands/index.ts

lunelson force-pushed the ln/fe-845-brunch-chrome-pass-ii branch from 61eaa48 to a28d57f Compare June 11, 2026 14:36

lunelson force-pushed the ln/fe-847-dx-introspection-tier-2 branch 2 times, most recently from 8e0d89d to f100a96 Compare June 11, 2026 14:38

lunelson force-pushed the ln/fe-845-brunch-chrome-pass-ii branch from a28d57f to bfa2b32 Compare June 11, 2026 14:38

Base automatically changed from ln/fe-847-dx-introspection-tier-2 to next June 11, 2026 14:39

FE-845: Wire runtime posture slash commands

60451fb

lunelson force-pushed the ln/fe-845-brunch-chrome-pass-ii branch from bfa2b32 to 60451fb Compare June 11, 2026 14:40

lunelson merged commit 577f0d1 into next Jun 11, 2026
6 checks passed

lunelson deleted the ln/fe-845-brunch-chrome-pass-ii branch June 11, 2026 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FE-845: TUI chrome resolutions pass II#203

FE-845: TUI chrome resolutions pass II#203
lunelson merged 1 commit into
nextfrom
ln/fe-845-brunch-chrome-pass-ii

lunelson commented Jun 11, 2026 •

edited

Loading

Uh oh!

lunelson commented Jun 11, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Jun 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		Custom TUI controls are explicitly out of scope. The experimental `src/.pi/components/tui-lab/` segment/chip components are promising for a follow-on posture picker or overlay, but this slice should not couple runtime authority to that exploratory UI.

Conversation

lunelson commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stack Context

What?

Uh oh!

lunelson commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lunelson commented Jun 11, 2026 •

edited

Loading

lunelson commented Jun 11, 2026 •

edited

Loading

cursor Bot commented Jun 11, 2026 •

edited

Loading