FE-848: Prompt context refinement#204
Conversation
PR SummaryLow Risk Overview Docs and architecture registers codify the seed-then- Tests cover the seed CLI contract and a Brunch RPC tracer that seeds one workbench and proves Reviewed by Cursor Bugbot for commit 3134c43. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2cb5b4f. Configure here.
There was a problem hiding this comment.
Pull request overview
This PR refines the dev seed-fixture protocol to make seeding explicit and workspace-scoped (no ambient “seed everything into current cwd”), and updates tests/docs/spec/plan to reflect and validate that behavior.
Changes:
- Replace the prior “seed all sets into cwd” flow with an explicit
runSeedFixturesClithat requires--workspace+--seed <set>/<slug>and seeds exactly one fixture. - Add CLI contract tests for argument validation and workspace isolation; add an app-level RPC test proving
--cwdinspects the targeted workspace DB. - Update SPEC/PLAN and
.fixtures/documentation to clarify the seeds/workbenches/runs/scratch separation and the explicit seeding workflow.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/graph/seed-fixtures.ts | Introduces explicit seed CLI parsing and single-fixture seeding into a named workspace DB. |
| src/graph/seed-fixtures.test.ts | Adds CLI-focused tests for safe arg parsing, workspace targeting, and single-fixture behavior. |
| src/app/brunch.test.ts | Adds an integration-style check that RPC state reflects the targeted --cwd workspace (not shell cwd). |
| memory/SPEC.md | Refines fixture/seed/workbench protocol and records the I48-L validation progress. |
| memory/PLAN.md | Updates the dev-seed-fixtures frontier to reflect the folded-in FE-848 hardening slice and acceptance leaves. |
| .fixtures/workbenches/live-graph-observer/README.md | Documents the new explicit “seed then launch with --cwd” workflow and removes unsupported launch modes. |
| .fixtures/README.md | Adds canonical seed + workbench usage guidance and clarifies non-implicit seeding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const destinationDb = join(parsed.workspace, '.brunch', 'data.db'); | ||
| const fixture = await readSelectedSeed(parsed.seed.set, parsed.seed.slug); | ||
| const executor = await openWorkspaceCommandExecutor(parsed.workspace); | ||
| const result = seedFixture(executor, fixture); | ||
| stdout( | ||
| `seeded ${parsed.seed.ref} → spec ${result.specId} ` + | ||
| `(${result.nodeCount} nodes, ${result.edgeCount} edges)\n`, | ||
| ); | ||
| stdout(`Destination: ${destinationDb}\n`); | ||
| return 0; |
| await runSeedFixturesCli({ | ||
| argv: ['--workspace', seededWorkspace, '--seed', 'workspace-spread/alpha-grounding'], | ||
| cwd: shellCwd, | ||
| stdout: () => {}, | ||
| }); |
da0360b to
b944790
Compare
2cb5b4f to
871b41d
Compare
b944790 to
61eaa48
Compare
871b41d to
6afeaa8
Compare
61eaa48 to
a28d57f
Compare
9496d36 to
ed274da
Compare
a28d57f to
bfa2b32
Compare
ed274da to
8f5fa32
Compare
bfa2b32 to
60451fb
Compare
8f5fa32 to
3134c43
Compare


Stack Context
This PR refines FE-848 prompt context and fixture protocol behavior at the top of the current stack.
What?