Skip to content

AddFrame handling of models #5965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
biotinker wants to merge 5 commits into
base: main
Choose a base branch
from
+211 −180
Draft

AddFrame handling of models #5965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e196a0
Proper unmarshaling of framesystems with flattened frames
biotinker Apr 24, 2026
ea58a58
Unify frame addition via AddFrame
biotinker Apr 24, 2026
2946d28
Merge branch 'main' into 20260424_framesystem_simplification
biotinker Apr 24, 2026
0d71b1a
cleanup
biotinker Apr 25, 2026
bb13a34
Better unmarshal
biotinker Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions referenceframe/frame.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,6 +926,9 @@ func framesAlmostEqual(frame1, frame2 Frame, epsilon float64) (bool, error) {
return false, nil
}
}
case *namedFrame:
f2 := frame2.(*namedFrame)
return framesAlmostEqual(f1.Frame, f2.Frame, epsilon)
default:
return false, fmt.Errorf("equality conditions not defined for %t", frame1)
}
Expand Down
Loading
Loading