CA Extension to strips by bdanzi · Pull Request #47090 · cms-sw/cmssw

bdanzi · 2025-01-13T09:46:54Z

PR description:

This PR should introduce the usage of strips layers to the offline reco and HLT Cellular Automaton (CA) usage (work done in 15_0_0_pre1):

the strip addition and the changes in performance are expected only if using the customizer customizeHLTforAlpakaStrip for HLT and stripNTupletFit for offline reco, final geometry (Geometry/CommonTopologies/interface/SimplePixelStripTopology.py) pairs is still work in progress
little gain in performance for the CA applied to pixel only due to the removal of minYsizeB1 and minYsizeB2 cuts + generalization of Kernel_simpleTripletCleaner
Test on TTbar PU EOR3 TRK DPG v7:
http://uaf-3.t2.ucsd.edu/~bdanzi/plots_pixelsOnlyValidation_AllCases/plots_hlt_hltPixel/effandfakePtEtaPhi.png where results in blue and red are produced with a cleaned 14_2_0 CMSSW release while the black one comes along with this PR changes

PR validation:

Before submitting I was checking

basic test procedure suggested in the CMSSW PR instructions, some of them still failing with exception like:

A std::exception was thrown.
Connection on "frontier://(preferipfamily=0)(proxyconfigurl=http://grid-wpad/wpad.dat)(backupproxyurl=http://cmst0frontier.cern.ch:3128)(backupproxyurl\
=http://cmst0frontier1.cern.ch:3128)(backupproxyurl=http://cmst0frontier2.cern.ch:3128)(backupproxyurl=http://cmsbpfrontier.cern.ch:3128)(backupproxyur\
l=http://cmsbpfrontier1.cern.ch:3128)(backupproxyurl=http://cmsbpfrontier2.cern.ch:3128)(backupproxyurl=http://cmsbproxy.fnal.gov:3128)(serverurl=http:\
//cmsfrontier.cern.ch:8000/FrontierProd)(serverurl=http://cmsfrontier1.cern.ch:8000/FrontierProd)(serverurl=http://cmsfrontier2.cern.ch:8000/FrontierPr\
od)(serverurl=http://cmsfrontier3.cern.ch:8000/FrontierProd)(serverurl=http://cmsfrontier4.cern.ch:8000/FrontierProd)/CMS_CONDITIONS" cannot be establi\
shed ( CORAL : "ConnectionPool::getSessionFromNewConnection" from "CORAL/Services/ConnectionService" )
----- End Fatal Exception -------------------------------------------------

cc @mmasciov @slava77
Work co-authored-by: @AdrianoDee Adriano Di Florio adriano.di.florio@cern.ch

cmsbuild · 2025-01-13T09:47:16Z

bdanzi, CMSSW_15_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

cmsbuild · 2025-01-13T09:47:38Z

cms-bot internal usage

cmsbuild · 2025-01-13T09:50:21Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47090/43269

There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/SiPixelHeterogeneous/plugins/SiPixelCompareRecHitsSoA.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File DQM/SiPixelHeterogeneous/plugins/SiPixelCompareTrackSoA.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File DQM/SiPixelHeterogeneous/plugins/SiPixelMonitorTrackSoA.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File DQM/SiPixelHeterogeneous/python/SiPixelHeterogenousDQM_FirstStep_cff.py modified in PR(s): [Do not merge] Testing Python formatting workflow with cmsbot #45616, Remove the configuration of the legacy CUDA workflows #46076
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): Replace configuration-copying Alpaka ESProducers with MoveToDeviceCache #47047
- File RecoLocalTracker/SiPixelRecHits/python/PixelCPEESProducers_cff.py modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoLocalTracker/SiPixelRecHits/src/PixelCPEFast.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoTracker/PixelSeeding/plugins/BuildFile.xml modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoTracker/PixelSeeding/plugins/CAHitNtupletGeneratorKernels.h modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoTracker/PixelSeeding/plugins/alpaka/BrokenLineFit.dev.cc modified in PR(s): Replace TAcc with explicit accelerator type #46916
- File RecoTracker/PixelSeeding/plugins/alpaka/CACell.h modified in PR(s): Replace TAcc with explicit accelerator type #46916
- File RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtuplet.cc modified in PR(s): Use TkPixelCPERecord for PixelCPEFastParams* #46852
- File RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernels.dev.cc modified in PR(s): Replace TAcc with explicit accelerator type #46916
- File RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): Replace TAcc with explicit accelerator type #46916
- File RecoTracker/PixelSeeding/plugins/alpaka/CAPixelDoubletsAlgos.h modified in PR(s): Replace TAcc with explicit accelerator type #46916
- File RecoTracker/PixelSeeding/plugins/alpaka/RiemannFit.dev.cc modified in PR(s): Replace TAcc with explicit accelerator type #46916
- File RecoTracker/PixelTrackFitting/plugins/PixelTrackProducerFromSoA.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoTracker/PixelTrackFitting/python/PixelTracks_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File RecoVertex/Configuration/python/RecoPixelVertexing_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47090/43269/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47090/43269/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

…mat checked

cmsbuild · 2025-01-13T10:00:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47090/43271

There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/SiPixelHeterogeneous/plugins/SiPixelCompareRecHitsSoA.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File DQM/SiPixelHeterogeneous/plugins/SiPixelCompareTrackSoA.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File DQM/SiPixelHeterogeneous/plugins/SiPixelMonitorTrackSoA.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File DQM/SiPixelHeterogeneous/python/SiPixelHeterogenousDQM_FirstStep_cff.py modified in PR(s): [Do not merge] Testing Python formatting workflow with cmsbot #45616, Remove the configuration of the legacy CUDA workflows #46076
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): Replace configuration-copying Alpaka ESProducers with MoveToDeviceCache #47047
- File RecoLocalTracker/SiPixelRecHits/python/PixelCPEESProducers_cff.py modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoLocalTracker/SiPixelRecHits/src/PixelCPEFast.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoTracker/PixelSeeding/plugins/BuildFile.xml modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoTracker/PixelSeeding/plugins/CAHitNtupletGeneratorKernels.h modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoTracker/PixelSeeding/plugins/alpaka/BrokenLineFit.dev.cc modified in PR(s): Replace TAcc with explicit accelerator type #46916
- File RecoTracker/PixelSeeding/plugins/alpaka/CACell.h modified in PR(s): Replace TAcc with explicit accelerator type #46916
- File RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtuplet.cc modified in PR(s): Use TkPixelCPERecord for PixelCPEFastParams* #46852
- File RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernels.dev.cc modified in PR(s): Replace TAcc with explicit accelerator type #46916
- File RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): Replace TAcc with explicit accelerator type #46916
- File RecoTracker/PixelSeeding/plugins/alpaka/CAPixelDoubletsAlgos.h modified in PR(s): Replace TAcc with explicit accelerator type #46916
- File RecoTracker/PixelSeeding/plugins/alpaka/RiemannFit.dev.cc modified in PR(s): Replace TAcc with explicit accelerator type #46916
- File RecoTracker/PixelTrackFitting/plugins/PixelTrackProducerFromSoA.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoTracker/PixelTrackFitting/python/PixelTracks_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File RecoVertex/Configuration/python/RecoPixelVertexing_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076

cmsbuild · 2025-01-13T10:00:46Z

Pull request #47090 was updated.

AdrianoDee · 2025-01-13T12:58:00Z

please test

mmusich · 2025-06-19T07:02:34Z

-hlt

this PR / branch looks unattended since a long time

cmsbuild · 2025-09-10T06:55:27Z

Milestone for this pull request has been moved to CMSSW_16_0_X. Please open a backport if it should also go in to CMSSW_15_1_X.

mmusich · 2025-10-07T09:27:20Z

@bdanzi does it make sense to keep this PR open? It conflicts with many other recent development PRs thus generating a lot of boilerplate messages from the bot at every new commit. If this is unattended can it be closed?

bdanzi · 2025-10-07T12:48:12Z

@bdanzi does it make sense to keep this PR open? It conflicts with many other recent development PRs thus generating a lot of boilerplate messages from the bot at every new commit. If this is unattended can it be closed?

Going to temporarily close it.

jfernan2 · 2025-11-10T08:40:12Z

-1
To clean the queue

Brunella DAnzi added 2 commits January 13, 2025 01:15

CA Extension to strips unique commit

402e41a

CA Extension to strips unique commit, merge to CMSSW_15_0_X

3ce3dd0

cmsbuild changed the base branch from CMSSW_15_0_X to master January 13, 2025 09:47

cmsbuild added this to the CMSSW_15_0_X milestone Jan 13, 2025

cmsbuild added reconstruction-pending dqm-pending hlt-pending geometry-pending operations-pending pending-signatures tests-pending orp-pending code-checks-pending heterogeneous-pending tracking trk changes-dataformats labels Jan 13, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 13, 2025

CA Extension to strips unique commit, merge to CMSSW_15_0_X, code-for…

43d60d7

…mat checked

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 13, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 13, 2025

This was referenced May 22, 2025

Update FastSim 2024 Era, add 2025 workflow #48153

Merged

Phase2-hgx364 Make a new scenario Run4D121 using D116 + corrected RPC with the corresponding workflow 34434.0 #48165

Merged

This was referenced Jun 11, 2025

Phase2-hgx364P1 Update the workflow for V19 version of HGCal scenarios #48292

Merged

Customization for HLT doublet-recovery tracking iteration with mkFit #48316

Merged

cmsbuild mentioned this pull request Jun 18, 2025

Adapt template pixel cpe algo to better handle shortened or broken clusters #48356

Merged

This was referenced Jun 20, 2025

Updated SoA View accessors from raw pointers to span #48377

Merged

Extend NanoAOD for NGT Phase 2 Scouting with Tau and Gen information #48425

Merged

This was referenced Jul 3, 2025

Fix for n_layers Check in CAHitNtupletAlpaka::globalBeginRun #48477

Merged

LST: add trackToTrack comparisons for GPU vs CPU tracking #48508

Merged

cmsbuild mentioned this pull request Jul 22, 2025

Implement template helper functions to reduce macro depencencies in SoA backend #48605

Closed

This was referenced Aug 6, 2025

Add a relval test for the NGT scouting menu with multiple process modifiers #48687

Merged

add ageing customization to ph2_hlt workflows #48695

Merged

HLT:75e33_trackingOnly and a related reference workflow #48706

Merged

cmsbuild mentioned this pull request Aug 18, 2025

fix ticl barrel in ph-2 HLT configuration #48756

Merged

This was referenced Aug 26, 2025

Add ZEE_14 workflows to TICLv5 procModifier #48801

Merged

add 2025 to the allowed 0T pp collisions workflows (.24 modifier) #48809

Merged

This was referenced Sep 5, 2025

TICLv5 Adjust Linking step #48851

Merged

Removed workaround for illegal memory access #48854

Merged

This was referenced Sep 12, 2025

[NGT] Extension of CA Pixel Tracking to Phase 2 Outer Tracker barrel #48921

Merged

add support for multiple input FEDs in HLTL1NumberFilter #48957

Merged

cmsbuild mentioned this pull request Sep 29, 2025

Fixes for Digi Morphing: Limiting Histogram Size and Decoupling for TrackerTraits #49021

Merged

cmsbuild mentioned this pull request Oct 7, 2025

HLT menu development for 15_0_X (11/N) [16_0_X] #49079

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CA Extension to strips#47090

CA Extension to strips#47090
bdanzi wants to merge 10 commits intocms-sw:masterfrom
bdanzi:CA_15_0_0_pre1_cleaned_reset

bdanzi commented Jan 13, 2025 •

edited

Loading

Uh oh!

cmsbuild commented Jan 13, 2025

Uh oh!

cmsbuild commented Jan 13, 2025 •

edited

Loading

Uh oh!

cmsbuild commented Jan 13, 2025

Uh oh!

cmsbuild commented Jan 13, 2025

Uh oh!

cmsbuild commented Jan 13, 2025

Uh oh!

AdrianoDee commented Jan 13, 2025

Uh oh!

mmusich commented Jun 19, 2025

Uh oh!

cmsbuild commented Sep 10, 2025

Uh oh!

mmusich commented Oct 7, 2025

Uh oh!

bdanzi commented Oct 7, 2025

Uh oh!

jfernan2 commented Nov 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

bdanzi commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Jan 13, 2025

Uh oh!

cmsbuild commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 13, 2025

Uh oh!

cmsbuild commented Jan 13, 2025

Uh oh!

cmsbuild commented Jan 13, 2025

Uh oh!

AdrianoDee commented Jan 13, 2025

Uh oh!

mmusich commented Jun 19, 2025

Uh oh!

cmsbuild commented Sep 10, 2025

Uh oh!

mmusich commented Oct 7, 2025

Uh oh!

bdanzi commented Oct 7, 2025

Uh oh!

jfernan2 commented Nov 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

bdanzi commented Jan 13, 2025 •

edited

Loading

cmsbuild commented Jan 13, 2025 •

edited

Loading