feat: wire native FME traffic type and rollout status lists by ravindraharness · Pull Request #838 · harness/mcp-server

ravindraharness · 2026-08-19T11:15:12Z

Description

Follow-up to #806: wire existing fme_traffic_type.list and fme_rollout_status.list to public v4 when callers pass org_id+project_id. Legacy workspace_id Split Admin paths stay (dual-mode). These lists already existed in MCP; this PR does not drop them.

Get/create/update/delete are not added — the registry still only exposes list (agents discover that from the tool surface, not from description restatement).

Dual-mode routing — this PR only

Resource	Legacy (`workspace_id`)	Harness-native (`org_id`+`project_id`)
`fme_traffic_type`	list (Split Admin, unchanged)	list (`GET /fme/api/v4/traffic-types`)
`fme_rollout_status`	list (Split Admin, unchanged)	list (`GET /fme/api/v4/rollout-statuses`)

Native contracts

Pagination: offset / limit (default 100, max 100). harness_list size maps to limit.
Response: fmeV4PaginatedListExtract promotes data → items and totalCount → total (not a raw passthrough envelope).
Mixed workspace_id + org_id/project_id is rejected by the existing dual-mode helper.

Tool-facing descriptions cover dual-mode scope, how to use harness_list, and pagination. They do not include HTTP paths, list-only restatement, or native payload field names (displayAttributeId, {data, totalCount}, etc.). README still documents the native item fields for humans.

feature-flag-rollout step 4 lists fme_rollout_status in native mode (no longer treated as NYI).

Key implementation changes

src/registry/toolsets/feature-flags.ts — dual-mode routeResolver for both list ops; descriptions kept tool-facing.
src/registry/extractors.ts — fmeV4PaginatedListExtract.
src/prompts/feature-flag-rollout.ts — native rollout-status list is usable.
README Feature Flags blurbs for both resources.
tests/registry/feature-flags.test.ts — native/legacy routing, FME scope params, and description guards (no HTTP paths / List-only / Native items / displayAttributeId).

Type of Change

New feature

Checklist

Unit: tests/registry/feature-flags.test.ts (fme_traffic_type and fme_rollout_status dual-mode list)
Tool descriptions do not expose HTTP paths or native payload schemas (review follow-up)

Coding Standards (registry-driven MCP model)

No new server.registerTool() calls — existing feature-flags toolset extended
operationPolicy on every changed endpoint
Shared response extractors from src/registry/extractors.ts
identifierFields and scope declared
No console.log() in src/

Test plan

Native list uses /fme/api/v4/traffic-types and /fme/api/v4/rollout-statuses with organization_identifier / project_identifier
Legacy list keeps Split Admin /internal/api/v2/... paths
Descriptions stay tool-facing
Live harness_list against QA with org_id+project_id for both resource types

List already existed on the Split Admin contract, so keep workspace_id dual-mode and add the public v4 org/project paths instead of dropping legacy. Co-authored-by: Cursor <cursoragent@cursor.com>

CLAassistant · 2026-08-19T11:15:20Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ puthrayaharness
❌ cursoragent
❌ ravindraharness
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Map size to Java limit, promote totalCount/data to total/items, and lock Harness auth in tests so v4 lists are not sent to Split. Co-authored-by: Cursor <cursoragent@cursor.com>

Java SegmentKind and EnvironmentListResponse are uppercase paginated contracts. MCP listed/created with lowercase type and dropped totalCount.

This reverts commit df868f3.

puthrayaharness · 2026-08-20T00:51:14Z

      displayName: "FME Rollout Status",
      description:
-        "Rollout status definitions for a workspace (e.g. Killed, Permanent, Ramping). Use to discover valid rollout_status_id UUIDs for filtering fme_feature_flag lists. Note: this endpoint may not be available on all account types — rollout status IDs are also returned inline with fme_feature_flag list results.",
+        "Rollout status definitions (e.g. Killed, Permanent, Ramping). Dual-mode list: org_id+project_id (Harness-native GET /fme/api/v4/rollout-statuses) or deprecated workspace_id (Split Admin). Use to discover rollout_status_id UUIDs for filtering fme_feature_flag lists. Native response is {data, limit, offset, totalCount}; each item is {type: \"ROLLOUT_STATUS\", id, name, description?}. List-only — no get/create/update/delete.",


Let's avoid exposing the details of endpoint in the description.

puthrayaharness · 2026-08-20T00:55:23Z

      displayName: "FME Traffic Type",
      description:
-        "Traffic type in a workspace (e.g. 'user', 'account'). List traffic types to discover traffic_type_id values needed for identity queries and flag/segment creation.",
+        "Traffic type (e.g. 'user', 'account'). Dual-mode list: org_id+project_id (Harness-native GET /fme/api/v4/traffic-types) or deprecated workspace_id (Split Admin). Use to discover traffic_type_id / name values for flag and segment create. Native items are {type: \"TRAFFIC_TYPE\", id, name} — no displayAttributeId. List-only — no get/create/update/delete.",


Same here let's avoid exposing the details of the underlying end points. Provide details of tool.

Also it is clear that is listing and has not GET/CREATE etc

Remove API path and response envelope details from the resource description per review feedback; keep dual-mode scoping guidance. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>

Replace resource description with tool-focused wording: list-only via harness_list, dual-mode scoping, and pagination. Removes underlying API path and Split Admin references per review feedback. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>

Review asked for MCP tool semantics (scope, pagination, item fields), not HTTP paths or list-only restatement.

Review asked for tool semantics (scope and pagination), not wire-shape fields such as displayAttributeId. Co-authored-by: Cursor <cursoragent@cursor.com>

puthrayaharness · 2026-08-20T22:14:08Z

@cursor Can you resolve the merge conflicts and push?

cursor · 2026-08-20T22:14:16Z

I've successfully resolved the merge conflicts and pushed the changes.

What I did:

Merged main into the fme-v4-traffic-type-rollout-status branch
Resolved a conflict in README.md by:
- Keeping the more detailed fme_feature_flag_definition description from main (which includes info about native-only operations)
- Keeping the updated fme_rollout_status dual-mode list implementation from this branch (which is what this PR adds)
Committed the merge with a descriptive message
Pushed the changes to the remote repository

Current status:

Branch: fme-v4-traffic-type-rollout-status
PR: #838
State: OPEN and MERGEABLE ✓
Latest commit: 3c227df7 (merge commit)

The PR is now ready for further review and can be merged when approved.

feat: wire native FME traffic type and rollout status lists

9dd5991

List already existed on the Split Admin contract, so keep workspace_id dual-mode and add the public v4 org/project paths instead of dropping legacy. Co-authored-by: Cursor <cursoragent@cursor.com>

ravindraharness and others added 3 commits August 19, 2026 17:19

fix: make native traffic and rollout lists harness_list-ready

47d003e

Map size to Java limit, promote totalCount/data to total/items, and lock Harness auth in tests so v4 lists are not sent to Split. Co-authored-by: Cursor <cursoragent@cursor.com>

fix: align FME segment kinds and environment list with v4

df868f3

Java SegmentKind and EnvironmentListResponse are uppercase paginated contracts. MCP listed/created with lowercase type and dropped totalCount.

Revert "fix: align FME segment kinds and environment list with v4"

10befe0

This reverts commit df868f3.

puthrayaharness requested changes Aug 20, 2026

View reviewed changes

cursoragent and others added 2 commits August 20, 2026 00:56

fix: simplify fme_rollout_status description without endpoint details

c3ae868

Remove API path and response envelope details from the resource description per review feedback; keep dual-mode scoping guidance. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>

ravindraharness requested a review from puthrayaharness August 20, 2026 05:25

ravindraharness and others added 2 commits August 20, 2026 14:43

fix: keep traffic and rollout list copy tool-facing

10305ce

Review asked for MCP tool semantics (scope, pagination, item fields), not HTTP paths or list-only restatement.

fix: drop native payload fields from traffic and rollout list copy

72ec755

Review asked for tool semantics (scope and pagination), not wire-shape fields such as displayAttributeId. Co-authored-by: Cursor <cursoragent@cursor.com>

This was referenced Aug 20, 2026

fix: accept native FME flag create aliases and align leftover agent docs #830

Closed

feat: wire native FME feature flag definition list, delete, and execute #831

Merged

puthrayaharness approved these changes Aug 20, 2026

View reviewed changes

Merge branch 'main' into fme-v4-traffic-type-rollout-status

83e92a6

puthrayaharness approved these changes Aug 20, 2026

View reviewed changes

puthrayaharness merged commit 724c45c into harness:main Aug 20, 2026
8 checks passed

cursor Bot mentioned this pull request Aug 20, 2026

chore: coding standards compliance review and test coverage #845

Draft

12 tasks

Navigation Menu

Uh oh!

feat: wire native FME traffic type and rollout status lists - #838

feat: wire native FME traffic type and rollout status lists#838
puthrayaharness merged 9 commits into
harness:mainfrom
ravindraharness:fme-v4-traffic-type-rollout-status

ravindraharness commented Aug 19, 2026 •

edited

Loading

Uh oh!

CLAassistant commented Aug 19, 2026 •

edited

Loading

Uh oh!

puthrayaharness Aug 20, 2026

Uh oh!

puthrayaharness Aug 20, 2026

Uh oh!

puthrayaharness commented Aug 20, 2026

Uh oh!

cursor Bot commented Aug 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ravindraharness commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dual-mode routing — this PR only

Native contracts

Key implementation changes

Type of Change

Checklist

Coding Standards (registry-driven MCP model)

Test plan

Uh oh!

CLAassistant commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

puthrayaharness Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

puthrayaharness Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

puthrayaharness commented Aug 20, 2026

Uh oh!

cursor Bot commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ravindraharness commented Aug 19, 2026 •

edited

Loading

CLAassistant commented Aug 19, 2026 •

edited

Loading

cursor Bot commented Aug 20, 2026 •

edited

Loading